build-sys: Require explicit make schema-update to regenerate#1308
Merged
openshift-merge-robot merged 1 commit intocoreos:masterfrom Apr 2, 2020
Merged
build-sys: Require explicit make schema-update to regenerate#1308openshift-merge-robot merged 1 commit intocoreos:masterfrom
make schema-update to regenerate#1308openshift-merge-robot merged 1 commit intocoreos:masterfrom
Conversation
Member
|
Makes sense to me! Let's see what others think. |
Member
|
/lgtm |
Alternative to coreos#1306 My recent change to use make for this seems to have introduced a race condition mainly in Prow; perhaps something is not preserving timestamps. Files stored in git should not be touched via a default make, as that is both subject to timestamp problems and also creates friction. So this change now requires an explicit manual generation; and we also consistently add the generated doc file to git too.
cgwalters
force-pushed
the
make-schemaupdate
branch
from
3573173 to
cfc64f6
Compare
Member
Author
|
OK rebased 🏄♂️ and also fixed up to make the two generated files consistently stored in git, updated manually. |
Member
|
/lgtm |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon, miabbott, mike-nguyen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/test sanity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #1306
My recent change to use make for this seems to have introduced
a race condition mainly in Prow; perhaps something is not
preserving timestamps.
Files stored in git should not be touched
via a default make, as that is both subject to timestamp
problems and also creates friction.
So this change now requires an explicit manual generation.