fix: Empty Conditional Effects Showing Empty Conditions#2986
Merged
CaveMobster merged 2 commits intocrowbartools:v5from Feb 11, 2025
Merged
fix: Empty Conditional Effects Showing Empty Conditions#2986CaveMobster merged 2 commits intocrowbartools:v5from
CaveMobster merged 2 commits intocrowbartools:v5from
Conversation
- String comparisons in eval() contexts weren't equating "" to null. - So add explicit empty string checks in four places. - This adds back "[Not Set]" to display of conditional effects.
CaveMobster
approved these changes
Feb 11, 2025
phroggster
added a commit
to phroggster/Firebot
that referenced
this pull request
Apr 6, 2025
- This was overlooked in crowbartools#2986.
ebiggz
added a commit
that referenced
this pull request
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adding a conditional effect then clearing the text of the condition used to display "[Not Set]" for the condition. This was changed, at some point in time (I'll leave it up to you to track down when this change occurred), and the conditions now appear as empty space, at least since Firebot v.5.63.2.
This PR changes it back to how it used to be, and instead displays "[Not Set]" again for empty conditions.
Applicable Issues
#2985
Testing
Thoroughly tested with numerous condition types and values. Only formerly empty display values appear to have been changed, which is a promising sight.
Screenshots
Before:
After:
