fix(effects): Condition of 0 was displaying as [Not Set] (#3086)#3087
Merged
ebiggz merged 2 commits intocrowbartools:v5from Apr 7, 2025
Merged
fix(effects): Condition of 0 was displaying as [Not Set] (#3086)#3087ebiggz merged 2 commits intocrowbartools:v5from
ebiggz merged 2 commits intocrowbartools:v5from
Conversation
- This was overlooked in crowbartools#2986.
ebiggz
reviewed
Apr 7, 2025
| $ctrl.$onInit = function() { | ||
| getRightSideValueDisplay().then((value) => { | ||
| $ctrl.rightSideValueDisplay = value || "[Not Set]"; | ||
| $ctrl.rightSideValueDisplay = value !== null && value !== undefined ? value : "[Not Set]"; |
Member
There was a problem hiding this comment.
This works just fine. But note that a single value != null check would be sufficient as it only checks null and undefined, it's not a full falsey check (that would catch 0).
ebiggz
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
[Not Set]in the overview.Applicable Issues
#3086
Testing
Tested numerous ways to potentially break it, some with absolutely atrocious conditions, and all appeared fine.
Screenshots