feat: enable vertical scrolling on network chooser screen#366
Conversation
Previously, if the content did not fit on the screen there was no way to view it unless the application window could be made larger
WalkthroughThe update modifies the UI rendering logic in the Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/ui/network_chooser_screen.rs (1)
645-650: Scroll area integration looks good – fine-tuneauto_shrink& persist scroll stateWrapping the table in a vertical
ScrollAreacleanly solves the clipping issue.
Two follow-ups you may want to consider:
auto_shrink([false; 2])disables shrink on both axes, which may introduce an unnecessary horizontal scrollbar on narrow windows. If vertical scrolling is the only goal,auto_shrink([false, true])(disable horizontal shrink only) is usually sufficient.Give the
ScrollAreaa stable ID with.id_source("network_table_scroll")so scroll position is preserved when the UI tree is rebuilt (e.g., after navigating away and back).Example diff:
egui::ScrollArea::vertical() - .auto_shrink([false; 2]) + .auto_shrink([false, true]) // only prevent vertical shrink + .id_source("network_table_scroll") // keep position between framesThese tweaks refine the UX without altering behavior.
Previously, if the content did not fit on the screen there was no way to view it unless the application window could be made larger
…364) * fix: Error loading identities from local DB on token creation screen * feat: add token by token id (#353) * feat: add token by token id * fmt * update cargo toml * fix: display error for invalid seed phrase in import wallet (#356) * fix: could not load identity with owner key (#357) * fix: overwrite dash.conf setting wasnt persisting (#358) * fix: hard to see password strength text with color (#359) * fix: message unclear when identity doesnt have appropriate private keys loaded (#360) * feat: token info button on tokens screen (#361) * Show tokens without description (#363) * feat: enable vertical scrolling on network chooser screen (#366) Previously, if the content did not fit on the screen there was no way to view it unless the application window could be made larger * fix: overwrite dash.conf setting still wasnt persisting and revert previous attempt (#372) * ok * fix * fmt * fix: missing dash-qt path * chore: remove .env and dash_core_configs from release workflow (#373) * chore: clippy * chore: review * feat: dark mode (#375) * feat: dark mode * ok * fmt * clippy * chore: bump version * fix: identity not found error when refreshing identities (#374) * fix: identity not found error when refreshing identities * chore: ui - gray out inactive identities * chore: minor ui fixes * chore: identity status creation failed cannot be reliably determined * fix: det overwrites pending/failed creation status * chore: copilot's review * chore: refactor * Update src/model/qualified_identity/mod.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: not needed migration call removed * chore: clippy --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: improved err msg on db migration failute. * chore: improve version number detection * feat: enhance input decoding to support multiple formats (#376) * feat: enhance input decoding to support multiple formats * more work * more work * feat: add context menu for contract actions in contract chooser panel (#378) * fix: token balance decimals (#379) * fix: token balances displaying decimals incorrectly * fix * fix * fmt * fix: token creator perpetual distribution was not allowing multiple ids per timestamp (#381) * chore: wallet is optional for identity - not tested --------- Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com> Co-authored-by: thephez <thephez@users.noreply.github.com> Co-authored-by: pauldelucia <pauldelucia2@gmail.com> Co-authored-by: pshenmic <pshenmic@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: QuantumExplorer <quantum@dash.org>
Note: I think there are other screens that have the same issue of sometimes displaying unreachable content. Probably all screens should be reviewed for that.
Previously, if the content did not fit on the screen there was no way to view it unless the application window could be made larger.
Summary by CodeRabbit