feat: enhance input decoding to support multiple formats#376
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
lklimek
pushed a commit
that referenced
this pull request
Jun 17, 2025
* feat: enhance input decoding to support multiple formats * more work * more work
QuantumExplorer
added a commit
that referenced
this pull request
Jun 26, 2025
…364) * fix: Error loading identities from local DB on token creation screen * feat: add token by token id (#353) * feat: add token by token id * fmt * update cargo toml * fix: display error for invalid seed phrase in import wallet (#356) * fix: could not load identity with owner key (#357) * fix: overwrite dash.conf setting wasnt persisting (#358) * fix: hard to see password strength text with color (#359) * fix: message unclear when identity doesnt have appropriate private keys loaded (#360) * feat: token info button on tokens screen (#361) * Show tokens without description (#363) * feat: enable vertical scrolling on network chooser screen (#366) Previously, if the content did not fit on the screen there was no way to view it unless the application window could be made larger * fix: overwrite dash.conf setting still wasnt persisting and revert previous attempt (#372) * ok * fix * fmt * fix: missing dash-qt path * chore: remove .env and dash_core_configs from release workflow (#373) * chore: clippy * chore: review * feat: dark mode (#375) * feat: dark mode * ok * fmt * clippy * chore: bump version * fix: identity not found error when refreshing identities (#374) * fix: identity not found error when refreshing identities * chore: ui - gray out inactive identities * chore: minor ui fixes * chore: identity status creation failed cannot be reliably determined * fix: det overwrites pending/failed creation status * chore: copilot's review * chore: refactor * Update src/model/qualified_identity/mod.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: not needed migration call removed * chore: clippy --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: improved err msg on db migration failute. * chore: improve version number detection * feat: enhance input decoding to support multiple formats (#376) * feat: enhance input decoding to support multiple formats * more work * more work * feat: add context menu for contract actions in contract chooser panel (#378) * fix: token balance decimals (#379) * fix: token balances displaying decimals incorrectly * fix * fix * fmt * fix: token creator perpetual distribution was not allowing multiple ids per timestamp (#381) * chore: wallet is optional for identity - not tested --------- Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com> Co-authored-by: thephez <thephez@users.noreply.github.com> Co-authored-by: pauldelucia <pauldelucia2@gmail.com> Co-authored-by: pshenmic <pshenmic@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: QuantumExplorer <quantum@dash.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update enhances the input decoding functionality across multiple visualizer screens. The input can now be provided in three formats: comma-separated integers, hex, or base64. The decoding process first checks for comma-separated integers, followed by hex and base64 decoding. This change improves user flexibility in inputting data and provides clearer error messages for invalid formats. The UI labels have also been updated to reflect these changes.