fix: identity not found error when refreshing identities#374
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/identity-not-found
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where refreshing identities fails when an identity from the local database is not found on the network by introducing a new status field and updating the related logic. Key changes include:
- Adding an IdentityStatus enum and related conversion traits in the model.
- Updating database schema and queries to use the new status field.
- Modifying UI and backend tasks to handle identity status updates appropriately.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/ui/tokens/tokens_screen/mod.rs | Tests updated to include the new status field for identity fixtures. |
| src/ui/identities/identities_screen.rs | Added status checks and refresh logic in the identities UI. |
| src/model/qualified_identity/mod.rs | Introduced the IdentityStatus enum and its conversions. |
| src/database/initialization.rs & src/database/identities.rs | Updated schema version, renamed column, and adjusted SQL queries. |
| src/context.rs | Removed legacy insert function and updated context usage accordingly. |
| src/backend_task/identity/* | Updated identity registration, refresh, and loading functions to use status. |
* fix: identity not found error when refreshing identities * chore: ui - gray out inactive identities * chore: minor ui fixes * chore: identity status creation failed cannot be reliably determined * fix: det overwrites pending/failed creation status * chore: copilot's review * chore: refactor * Update src/model/qualified_identity/mod.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: not needed migration call removed * chore: clippy --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…364) * fix: Error loading identities from local DB on token creation screen * feat: add token by token id (#353) * feat: add token by token id * fmt * update cargo toml * fix: display error for invalid seed phrase in import wallet (#356) * fix: could not load identity with owner key (#357) * fix: overwrite dash.conf setting wasnt persisting (#358) * fix: hard to see password strength text with color (#359) * fix: message unclear when identity doesnt have appropriate private keys loaded (#360) * feat: token info button on tokens screen (#361) * Show tokens without description (#363) * feat: enable vertical scrolling on network chooser screen (#366) Previously, if the content did not fit on the screen there was no way to view it unless the application window could be made larger * fix: overwrite dash.conf setting still wasnt persisting and revert previous attempt (#372) * ok * fix * fmt * fix: missing dash-qt path * chore: remove .env and dash_core_configs from release workflow (#373) * chore: clippy * chore: review * feat: dark mode (#375) * feat: dark mode * ok * fmt * clippy * chore: bump version * fix: identity not found error when refreshing identities (#374) * fix: identity not found error when refreshing identities * chore: ui - gray out inactive identities * chore: minor ui fixes * chore: identity status creation failed cannot be reliably determined * fix: det overwrites pending/failed creation status * chore: copilot's review * chore: refactor * Update src/model/qualified_identity/mod.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: not needed migration call removed * chore: clippy --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: improved err msg on db migration failute. * chore: improve version number detection * feat: enhance input decoding to support multiple formats (#376) * feat: enhance input decoding to support multiple formats * more work * more work * feat: add context menu for contract actions in contract chooser panel (#378) * fix: token balance decimals (#379) * fix: token balances displaying decimals incorrectly * fix * fix * fmt * fix: token creator perpetual distribution was not allowing multiple ids per timestamp (#381) * chore: wallet is optional for identity - not tested --------- Co-authored-by: Paul DeLucia <69597248+pauldelucia@users.noreply.github.com> Co-authored-by: thephez <thephez@users.noreply.github.com> Co-authored-by: pauldelucia <pauldelucia2@gmail.com> Co-authored-by: pshenmic <pshenmic@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: QuantumExplorer <quantum@dash.org>
When an identity from local db doesn't exist on the network, DET fails to refresh identity list.
Fixed this issue and implemented
statusfield that gives more detailed info about identity status.