bls: Refactor CBLSWrapper::SetBuf and CBLSWrapper::GetBuf#3867
Merged
xdustinface merged 6 commits intoDec 12, 2020
Conversation
This makes `CBLSImplicit` compatible (related to methods called by CBLSWrapper) with the other classes from the bls-signatures library.
This was referenced Dec 10, 2020
Author
How exactly? Can you explain what you mean? |
UdjinM6
reviewed
Dec 11, 2020
UdjinM6
approved these changes
Dec 11, 2020
PastaPastaPasta
approved these changes
Dec 12, 2020
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
Okay, looking at it more, this does looks like a good improvement.
utACK 👍
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jun 26, 2021
* bls: Add CBLSImplicit, a wrapper around uint256 This makes `CBLSImplicit` compatible (related to methods called by CBLSWrapper) with the other classes from the bls-signatures library. * bls: Use CBLSImplicit instead of uint256 as base type of CBLSId * bls: Use FromBytes directly instead of indirectly through InternalSetBuf * bls: Use Serialize directly instead of indirectly through InternalGetBuf * bls: Drop all occurrences of InternalSetBuf and InternalGetBuf * bls: Use `CBLSIdImplicit` instead of `uint256` in some more places
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 28, 2021
7514361 Correct misleading "overridden options" label (Hennadii Stepanov) Pull request description: Refs: dashpay#3867, bitcoin#8165. Tree-SHA512: da3b13a0560654053aeff22a15031ae59a3136abc941f3959440c2d250add7de7ca837c96d721eed69b2cac21d340e1895a186f69383ab82a41fc1e0ee789e5c
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 14, 2022
* bls: Add CBLSImplicit, a wrapper around uint256 This makes `CBLSImplicit` compatible (related to methods called by CBLSWrapper) with the other classes from the bls-signatures library. * bls: Use CBLSImplicit instead of uint256 as base type of CBLSId * bls: Use FromBytes directly instead of indirectly through InternalSetBuf * bls: Use Serialize directly instead of indirectly through InternalGetBuf * bls: Drop all occurrences of InternalSetBuf and InternalGetBuf * bls: Use `CBLSIdImplicit` instead of `uint256` in some more places
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some refactoring of
CBLSWrapper::GetBuf/CBLSWrapper::SetBufto simplify the BLS classes a bit.uint256was implicit type ofCBLSIdbut it doesn't provideFromBytesand the correct requiredSerializeto match the BLS primitives fromdashpay/bls-signatureswhich are used byCBLSWrapper.So 73d3271 + 2de99db are required to make 1df1d8b and 2c2e29d possible and b936f17 just drops not longer needed code.