refactor: Add/Use byte vector constructor for CBLSWrapper#3868
Merged
PastaPastaPasta merged 3 commits intoDec 14, 2020
Conversation
xdustinface
force-pushed
the
pr-refactor-bls-instantiation
branch
from
c9bc475 to
b8f1dd5
Compare
|
Looks good, will need rebase after #3871 to fix tests I guess. |
xdustinface
changed the title
…, CBLSPublicKey Allow them to access e.g. the new byte vector consructor.
xdustinface
force-pushed
the
pr-refactor-bls-instantiation
branch
from
b8f1dd5 to
20fb84b
Compare
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jun 30, 2021
* bls: Add CBLSWrapper constructor which accepts a byte vecor * bls: Bring CBLSWrapper::CBLSWrapper in scope of CBLSId, CBLSSecretKey, CBLSPublicKey Allow them to access e.g. the new byte vector consructor. * governance|init|privatesend|test: Refactor some BLS instantiations
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 12, 2022
* bls: Add CBLSWrapper constructor which accepts a byte vecor * bls: Bring CBLSWrapper::CBLSWrapper in scope of CBLSId, CBLSSecretKey, CBLSPublicKey Allow them to access e.g. the new byte vector consructor. * governance|init|privatesend|test: Refactor some BLS instantiations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
CBLSWrapper(const std::vector<unsigned char>& vecBytes)constructor and makes use of it in several places.Requires #3867 to work.Merged