llmq: Restrict ShouldSimulateError to trigger for LLMQ_TEST only#3871
Merged
Conversation
Current `develop` tests fail. This was basically introduced by dashpay#3844 but it didn't come up before dashpay#3853 because the `v17` fork wasn't activated in `feature_llmq_dkgerrors.py`. After dashpay#3853 `dip0008` activation takes [200 blocks](dashpay@b95cf01#diff-4a04bc0b355c780033960e8c261ee9b6d3c452897e1dcd88a15d272512266c76R539) which was normally activated after [10 blocks](dashpay@b95cf01#diff-b92fa0fafafa27172736ebc88f9f9b658b1160caca512a318eefb7d93d22bf3cL18) in `feature_llmq_dkgerrors.py`. Now with the 200 blocks `v17` gets activated during test which then leads to MN1, MN2 banning MN0 because it lies in DKG of `LLMQ_TEST` and `LLMQ_TEST_V17`. There are other ways to solve it, like enabling `dip0008` earlier or enable `v17` later but IMO its anyway better to restrict `ShouldSimulateError` to only trigger for `LLMQ_TEST`.
PastaPastaPasta
previously approved these changes
Dec 12, 2020
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK, I think this is fine to do...
|
Good catch! 👍 I agree that fixing |
… only" This reverts commit ec42d86.
…lternative) Move ShouldSimulateError into CDKGSession
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Apr 1, 2022
…ashpay#3871) * llmq: Restrict `ShouldSimulateError` to trigger for LLMQ_TEST only Current `develop` tests fail. This was basically introduced by dashpay#3844 but it didn't come up before dashpay#3853 because the `v17` fork wasn't activated in `feature_llmq_dkgerrors.py`. After dashpay#3853 `dip0008` activation takes [200 blocks](dashpay@b95cf01#diff-4a04bc0b355c780033960e8c261ee9b6d3c452897e1dcd88a15d272512266c76R539) which was normally activated after [10 blocks](dashpay@b95cf01#diff-b92fa0fafafa27172736ebc88f9f9b658b1160caca512a318eefb7d93d22bf3cL18) in `feature_llmq_dkgerrors.py`. Now with the 200 blocks `v17` gets activated during test which then leads to MN1, MN2 banning MN0 because it lies in DKG of `LLMQ_TEST` and `LLMQ_TEST_V17`. There are other ways to solve it, like enabling `dip0008` earlier or enable `v17` later but IMO its anyway better to restrict `ShouldSimulateError` to only trigger for `LLMQ_TEST`. * Revert "llmq: Restrict `ShouldSimulateError` to trigger for LLMQ_TEST only" This reverts commit ec42d86. * llmq: Restrict `ShouldSimulateError` to trigger for LLMQ_TEST only (alternative) Move ShouldSimulateError into CDKGSession Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current
developtests fail. This was basically introduced by #3844 but it didn't come up before #3853 because thev17fork wasn't activated infeature_llmq_dkgerrors.pyandUdjinM6:fixCLlogic_tweaktestsdidn't had #3844 in its history.After #3853
dip0008activation takes 200 blocks which was normally activated after 10 blocks infeature_llmq_dkgerrors.py. Now with the 200 blocksv17gets activated during test which then leads to MN1, MN2 banning MN0 because it lies in DKG ofLLMQ_TESTandLLMQ_TEST_V17.There are other ways to solve it, like enabling
dip0008earlier or enablev17later but IMO its anyway better to restrictShouldSimulateErrorto only trigger forLLMQ_TEST.