refactor: Use constructors instead of static initialiser in CBLSId#3869
Merged
PastaPastaPasta merged 5 commits intoDec 15, 2020
Merged
Conversation
xdustinface
force-pushed
the
pr-refactor-blsid-instantiations
branch
from
52574d7 to
be2e606
Compare
|
Looks ok-ish. What's the reason for moving implementation details (and |
Author
Good question 🙈 will change it with the rebase after #3871 |
xdustinface
changed the title
CBLSId instantiations
xdustinface
force-pushed
the
pr-refactor-blsid-instantiations
branch
from
be2e606 to
076c455
Compare
UdjinM6
reviewed
Dec 14, 2020
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jun 26, 2021
…ashpay#3869) * bls: Add CBLSId(const int64_t n) and CBLSId(const uint256& nHash) * bench|llmq: Refactor instantiations of CBLSId * bls: Drop CBLSId::{SetInt, SetHash, FromInt, FromHash} * Drop `CBLSId(int64_t)` ctor * Partially Revert "Drop `CBLSId(int64_t)` ctor" Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 14, 2022
…ashpay#3869) * bls: Add CBLSId(const int64_t n) and CBLSId(const uint256& nHash) * bench|llmq: Refactor instantiations of CBLSId * bls: Drop CBLSId::{SetInt, SetHash, FromInt, FromHash} * Drop `CBLSId(int64_t)` ctor * Partially Revert "Drop `CBLSId(int64_t)` ctor" Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
CBLSId(const int64_t n)andCBLSId(const uint256& nHash)constructor and makes use of it in several places.Based on #3867Merged