-
Notifications
You must be signed in to change notification settings - Fork 127
Fix lakeview publish to explicitly send embed_credentials as false by default #4066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lakeview publish to explicitly send embed_credentials as false by default #4066
Conversation
|
hey @andrewnester |
andrewnester
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment regarding tests but overall looks good! @denik could you TAL as well?
|
@andrewnester pushed the changes, |
|
Commit: 22007ee
23 interesting tests: 20 KNOWN, 2 flaky, 1 SKIP
Top 24 slowest tests (at least 2 minutes):
|
Head branch was pushed to by a user without write access
77a78a7 to
ec40595
Compare
ec40595 to
5dbf42a
Compare
|
@andrewnester there was a test failing on windows, fixed it, |
|
@andrewnester can we merge this ? |
|
@varundeepsaini we can merge this, could you add NEXT_CHANGELOG entry? |
|
@denik added |
|
@varundeepsaini did you push? I don't see it. |
|
my bad, pushed now |
|
@denik, is there any way I can determine which integration tests are failing? |
Head branch was pushed to by a user without write access
e00f349 to
c84c26b
Compare
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
Commit: e2f98af
47 interesting tests: 22 FAIL, 20 KNOWN, 4 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
## Release v0.281.0 ### CLI * Fix lakeview publish to default `embed_credentials` to false ([#4066](#4066)) ### Bundles * Add support for configurable catalog/schema for dashboards ([#4130](#4130)) * Pass SYSTEM\_ACCESSTOKEN from env to the Terraform provider ([#4135](#4135)) * `bundle deployment migrate`: when running `bundle plan` propagate `-var` arguments. * engine/direct: New option --plan to `bundle deploy` to deploy previously saved plan (saved plan with `bundle plan -o json`) ([#4134](#4134)) * engine/direct: Fix dependency-ordered deletion by persisting depends\_on in state ([#4105](#4105)) ### Dependency updates * Upgrade Go SDK to 0.94.0 ([#4148](#4148)) * Upgrade Terraform provider to 1.100.0 ([#4150](#4150))
Fixes: #4001
Changes
Add override for
lakeview publishto explicitly sendembed_credentials: falsewhen--embed-credentialsflag is not provided.Why
The SDK omits
falseboolean values from JSON requests due toomitempty. This caused the API to default totrue, embedding credentials even when the flag wasn't set. The fix usesForceSendFieldsto always send the value explicitly.Tests
Added acceptance test verifying the request body contains
"embed_credentials": false.