Add support for configurable catalog/schema for dashboards #4130
+348
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonli33-databricks
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
denik
reviewed
Dec 11, 2025
| RecordRequests = true | ||
|
|
||
| [EnvMatrix] | ||
| DATABRICKS_BUNDLE_ENGINE = ["direct"] |
Contributor
There was a problem hiding this comment.
Can you add a comment re terraform, why is it not tested there? Is it not implemented there?
Contributor
Author
There was a problem hiding this comment.
hey! the TF changes are in but have not been released yet. was chatting with @pietern who mentioned that we were unblocked for the direct deployment mode and we can implement the changes there first.
ill add a comment in the test
| WarehouseId: dashboard.WarehouseId, | ||
| SerializedDashboard: dashboard.SerializedDashboard, | ||
| ParentPath: ensureWorkspacePrefix(dashboard.ParentPath), | ||
| DatasetCatalog: "", |
Contributor
There was a problem hiding this comment.
Is it not possible to read these?
In general, we need to be able to read these fields to identify whether they were modified outside of DABs.
Contributor
There was a problem hiding this comment.
APIs which have a behaviour like this are likely not complaint with AIP.
Contributor
There was a problem hiding this comment.
I heard back from @pietern that we detect diff here via etags since the etag changes if these are modified. Can you please add a comment saying as much so future readers are also aware?
Contributor
Author
There was a problem hiding this comment.
good call, done 👍
- Add Terraform conversion test for dataset_catalog and dataset_schema - Update acceptance tests to run for both direct and terraform engines - Fix direct engine to skip write-only fields in remote diff computation - Add engine-specific expected output files for requests and plans - Update test script to generate engine-specific request files
pietern
changed the title
shreyas-goenka
approved these changes
Dec 17, 2025
denik
approved these changes
Dec 17, 2025
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Collaborator
|
Commit: ca21bfe
23 interesting tests: 20 KNOWN, 2 FAIL, 1 SKIP
Top 38 slowest tests (at least 2 minutes):
|
Contributor
|
Integration test failures are unrelated. |
Collaborator
|
Commit: b6349a4
39 interesting tests: 20 KNOWN, 16 FAIL, 2 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Dec 18, 2025
## Release v0.281.0 ### CLI * Fix lakeview publish to default `embed_credentials` to false ([#4066](#4066)) ### Bundles * Add support for configurable catalog/schema for dashboards ([#4130](#4130)) * Pass SYSTEM\_ACCESSTOKEN from env to the Terraform provider ([#4135](#4135)) * `bundle deployment migrate`: when running `bundle plan` propagate `-var` arguments. * engine/direct: New option --plan to `bundle deploy` to deploy previously saved plan (saved plan with `bundle plan -o json`) ([#4134](#4134)) * engine/direct: Fix dependency-ordered deletion by persisting depends\_on in state ([#4105](#4105)) ### Dependency updates * Upgrade Go SDK to 0.94.0 ([#4148](#4148)) * Upgrade Terraform provider to 1.100.0 ([#4150](#4150))
|
Hi @leonli33-databricks , nice feature! My problem is, that it doesn't work using databricks CLI v0.282.0 on Mac M4. After My databricks.yml looks like this: resources:
jobs:
...
tasks:
...
dashboards:
dashboard:
display_name: "Great Dashboard"
dataset_catalog: "catalog"
dataset_schema: "schema"How to analyze/fix? Any kind of support is highly appreciated! Best Regards! |
Contributor
Author
|
hey @hafeja! the error is saying that the default catalog and schema you used does not have the asset
also may be quicker to do this on slack, feel free to message me (Leon Li) |
|
Hi @leonli33-databricks, due to data protection, I cannot share the exact values. Dataset query excerpt: As soon as Is there any way to debug the issue? Any other ideas? In the output of Another strange behavior is that some VS Code linter complains (red line): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Support passing the
dataset_cataloganddataset_schemafields for dashboards.Example:
Tests
New acceptance tests.