Reverse dependency order for delete operations in direct engine #4105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varundeepsaini
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
varundeepsaini
force-pushed
the
fix/dependency-ordered-deletion
branch
from
d6ebbc5 to
2042b3a
Compare
Contributor
Author
|
@andrewnester @denik |
Contributor
|
Thanks @varundeepsaini this looks on the right track. You need to update output of all acceptance tests (make test-update) and deduplicate the entries: |
Collaborator
|
Commit: 7a2ff5e
8 interesting tests: 7 KNOWN, 1 SKIP
Top 25 slowest tests (at least 2 minutes):
|
denik
reviewed
Dec 10, 2025
acceptance/bundle/resource_deps/job_id/out.plan_delete.direct.json
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@denik |
denik
reviewed
Dec 11, 2025
Contributor
denik
left a comment
denik
left a comment
There was a problem hiding this comment.
Looks good, minor comments remaining. Please also rebase.
Added bundle/direct/graph_test.go
I don't see this file.
denik
reviewed
Dec 12, 2025
Contributor
Author
|
@denik can you review once again, and queue the tests (the integration tests as well) |
denik
reviewed
Dec 12, 2025
Contributor
|
Looks great! Please also update NEXT_CHANGELOG.md |
Contributor
Author
|
updated the changelog |
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Collaborator
|
Commit: 700366b
10 interesting tests: 7 KNOWN, 2 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Dec 18, 2025
## Release v0.281.0 ### CLI * Fix lakeview publish to default `embed_credentials` to false ([#4066](#4066)) ### Bundles * Add support for configurable catalog/schema for dashboards ([#4130](#4130)) * Pass SYSTEM\_ACCESSTOKEN from env to the Terraform provider ([#4135](#4135)) * `bundle deployment migrate`: when running `bundle plan` propagate `-var` arguments. * engine/direct: New option --plan to `bundle deploy` to deploy previously saved plan (saved plan with `bundle plan -o json`) ([#4134](#4134)) * engine/direct: Fix dependency-ordered deletion by persisting depends\_on in state ([#4105](#4105)) ### Dependency updates * Upgrade Go SDK to 0.94.0 ([#4148](#4148)) * Upgrade Terraform provider to 1.100.0 ([#4150](#4150))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4089
Changes
When deleting resources with dependencies, the direct deployment engine now deletes dependents before their dependencies. Previously, resources were deleted in deployment order, which could cause errors when a dependency was deleted before resources that depend on it.
Edge direction in the dependency graph is now determined per-node based on action type: