fix: Build errors — remove unused useRef, add @tiptap/suggestion dep,…#9
fix: Build errors — remove unused useRef, add @tiptap/suggestion dep,…#9devohmycode merged 1 commit intomasterfrom
Conversation
… bump tauri version to 0.6.1 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Review Summary by QodoFix build errors and bump Tauri to 0.6.1
WalkthroughsDescription• Add missing @tiptap/suggestion dependency to resolve build errors • Remove unused useRef import from BookmarkPanel component • Bump Tauri version from 0.5.0 to 0.6.1 • Update pnpm lock file with new dependency resolution Diagramflowchart LR
A["Build Issues"] --> B["Add @tiptap/suggestion"]
A --> C["Remove unused useRef"]
A --> D["Bump Tauri 0.5.0→0.6.1"]
B --> E["Updated Dependencies"]
C --> E
D --> E
File Changes1. package.json
|
Code Review by Qodo
1. package-lock not updated
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughDependencies and configuration updates have been applied. The Tiptap suggestion library was added to project dependencies, the Tauri configuration version was bumped to 0.6.1, and an unused React hook import was removed from a component. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| "@tiptap/extension-underline": "^3.20.0", | ||
| "@tiptap/react": "^3.20.0", | ||
| "@tiptap/starter-kit": "^3.20.0", | ||
| "@tiptap/suggestion": "^3.20.0", |
There was a problem hiding this comment.
1. Package-lock not updated 🐞 Bug ⛯ Reliability
package.json adds @tiptap/suggestion, but package-lock.json and README are still oriented around npm, making the repo inconsistent for npm users (npm ci may fail or npm install will rewrite the lockfile). CI uses pnpm, so contributors will get different dependency resolution depending on the tool they follow.
Agent Prompt
## Issue description
The repo currently mixes pnpm (CI + pnpm-lock.yaml) and npm (README + package-lock.json). This PR adds a direct dependency (`@tiptap/suggestion`) but does not reconcile the npm lockfile + docs, which can cause `npm ci` failures or uncommitted lockfile changes for contributors following the README.
## Issue Context
- CI installs dependencies with `pnpm install`.
- README instructs `npm install` / `npm run dev`.
- `package.json` now includes `@tiptap/suggestion`, but `package-lock.json` root deps list does not.
## Fix Focus Areas
- package.json[34-46]
- package-lock.json[6-48]
- README.md[195-223]
- .github/workflows/build.yml[44-54]
## Expected fix approaches (pick one)
1) **pnpm-first**: remove `package-lock.json`, update README to use pnpm, optionally add `"packageManager": "pnpm@<version>"`.
2) **dual-support**: regenerate and commit `package-lock.json` so it matches `package.json`, and clarify in README which lockfile/package manager is supported.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
… bump tauri version to 0.6.1
Summary by CodeRabbit
Release Notes