Skip to content

fix: Build errors — remove unused useRef, add @tiptap/suggestion dep,… #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devohmycode merged 1 commit into from
Feb 27, 2026
Merged

fix: Build errors — remove unused useRef, add @tiptap/suggestion dep,… #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"@tiptap/extension-underline": "^3.20.0",
"@tiptap/react": "^3.20.0",
"@tiptap/starter-kit": "^3.20.0",
"@tiptap/suggestion": "^3.20.0",
Copy link
Copy Markdown

@qodo-code-review qodo-code-review bot Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Package-lock not updated 🐞 Bug ⛯ Reliability

package.json adds @tiptap/suggestion, but package-lock.json and README are still oriented around
npm, making the repo inconsistent for npm users (npm ci may fail or npm install will rewrite the
lockfile). CI uses pnpm, so contributors will get different dependency resolution depending on the
tool they follow.
Agent Prompt 
## Issue description
The repo currently mixes pnpm (CI + pnpm-lock.yaml) and npm (README + package-lock.json). This PR adds a direct dependency (`@tiptap/suggestion`) but does not reconcile the npm lockfile + docs, which can cause `npm ci` failures or uncommitted lockfile changes for contributors following the README.

## Issue Context
- CI installs dependencies with `pnpm install`.
- README instructs `npm install` / `npm run dev`.
- `package.json` now includes `@tiptap/suggestion`, but `package-lock.json` root deps list does not.

## Fix Focus Areas
- package.json[34-46]
- package-lock.json[6-48]
- README.md[195-223]
- .github/workflows/build.yml[44-54]

## Expected fix approaches (pick one)
1) **pnpm-first**: remove `package-lock.json`, update README to use pnpm, optionally add `"packageManager": "pnpm@<version>"`.
2) **dual-support**: regenerate and commit `package-lock.json` so it matches `package.json`, and clarify in README which lockfile/package manager is supported.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

"class-variance-authority": "^0.7.1",
"clsx": "^2.1.1",
"framer-motion": "^12.34.1",
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src-tauri/tauri.conf.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://raw.githubusercontent.com/tauri-apps/tauri/dev/crates/tauri-config-schema/schema.json",
"productName": "SuperFlux",
"version": "0.5.0",
"version": "0.6.1",
"identifier": "com.ohmycode.superflux",
"build": {
"beforeDevCommand": "npm run dev:app",
Expand Down
2 changes: 1 addition & 1 deletion src/components/BookmarkPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useState, useEffect, useCallback, useRef } from 'react';
import { useState, useEffect, useCallback } from 'react';
import { motion } from 'motion/react';
import { useAuth } from '../contexts/AuthContext';
import { fetchBookmarks, removeBookmark, toggleBookmarkRead, type WebBookmark } from '../services/bookmarkService';
Expand Down