Skip to content

v0.0.9 Release Patch: Git clone change to HTTPS from SSH, get_data change, LFS changes#1092

Merged
spomichter merged 3 commits intomainfrom
dev
Jan 23, 2026
Merged

v0.0.9 Release Patch: Git clone change to HTTPS from SSH, get_data change, LFS changes#1092
spomichter merged 3 commits intomainfrom
dev

Conversation

@spomichter
Copy link
Contributor

No description provided.

jeff-hykin and others added 2 commits January 23, 2026 11:52
* add minimal fix for large files not updating

* add path
…to main branch (#1091)

* Change ssh to https git

* Change get data to https
@spomichter spomichter requested a review from a team January 23, 2026 20:04
paul-nechifor
paul-nechifor previously approved these changes Jan 23, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 23, 2026

Greptile Overview

Greptile Summary

This patch release addresses two critical deployment issues: switching from SSH to HTTPS for git clone operations and updating the default branch from dev to main.

Key Changes:

  • Changed all git clone commands from git@github.com:dimensionalOS/dimos.git to https://github.com/dimensionalOS/dimos.git for better accessibility (no SSH key setup required)
  • Updated _get_repo_root() to clone from main branch instead of dev
  • Added virtual environment-aware data directory handling to prevent conflicts between multiple venvs
  • Removed obsolete commented-out SSH installation command from README

Impact:

  • Improves onboarding experience - users can clone without SSH key configuration
  • Aligns automated repository cloning with the production main branch
  • Fixes issue where multiple virtual environments would conflict over shared data in ~/.local/share/dimos

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk - changes are primarily documentation and configuration updates
  • Score reflects straightforward changes (HTTPS migration, branch update) with one minor cross-platform consideration in the venv path construction that works but could be more robust
  • Pay attention to dimos/utils/data.py - the venv path construction uses hardcoded structure that may need testing across different Python environments

Important Files Changed

Filename Overview
README.md Removed commented-out SSH-based git command from documentation
README_installation.md Changed git clone from SSH to HTTPS for better accessibility
docs/development/README.md Updated all git clone commands from SSH to HTTPS (3 occurrences)
dimos/utils/data.py Added venv-specific data directory, changed git clone to HTTPS and main branch; potential cross-platform path issue

Sequence Diagram

sequenceDiagram
    participant User
    participant get_data
    participant _get_user_data_dir
    participant _get_repo_root
    participant Git

    User->>get_data: Request data file
    get_data->>_get_repo_root: Get repository location
    
    alt Running from git repo
        _get_repo_root-->>get_data: Return DIMOS_PROJECT_ROOT
    else Running as installed package
        _get_repo_root->>_get_user_data_dir: Get data directory
        
        alt VIRTUAL_ENV set
            _get_user_data_dir-->>_get_repo_root: venv/lib/python3.x/site-packages/dimos/data
        else Platform-specific paths
            alt Linux
                _get_user_data_dir-->>_get_repo_root: ~/.local/share/dimos
            else macOS
                _get_user_data_dir-->>_get_repo_root: ~/Library/Application Support/dimos
            else Other
                _get_user_data_dir-->>_get_repo_root: ~/.dimos
            end
        end
        
        alt Repository not cloned
            _get_repo_root->>Git: git clone --branch main https://github.com/dimensionalOS/dimos.git
            Git-->>_get_repo_root: Clone complete
        end
        
        _get_repo_root-->>get_data: Return repo_dir
    end
    
    alt File exists
        get_data-->>User: Return file path
    else File needs LFS pull
        get_data->>Git: git lfs pull
        Git-->>get_data: File downloaded
        get_data-->>User: Decompress and return path
    end
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment on lines +35 to +39
if os.environ.get("VIRTUAL_ENV"):
venv_data_dir = Path(
f"{os.environ.get('VIRTUAL_ENV')}/lib/python{sys.version_info.major}.{sys.version_info.minor}/site-packages/dimos/data"
)
return venv_data_dir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded path structure assumes Linux/Unix layout. Consider using site.getsitepackages() or sysconfig.get_path('purelib') for more reliable cross-platform venv detection.

@spomichter spomichter changed the title Release v0.0.8 Patch v0.0.9 Release Patch: Git clone change to HTTPS from SSH, get_data change, LFS changes Jan 23, 2026
@spomichter spomichter merged commit e4defcb into main Jan 23, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants