Fix LFS Updating Issue

[jeff-hykin]

• Tested on linux (mkdir temp, uv venv, pip install git url, dimos run --replay, LFS downloads successfully, replay runs)
• This is a tiny change to prevent conflicts/updates, later we'll properly fix the whole system

[greptile-apps]

Greptile Overview

Greptile Summary

Fixed a type consistency bug in _get_user_data_dir() where the virtual environment path was returned as a string instead of a Path object, causing LFS updating issues when running in virtual environments.

• Wrapped the venv_data_dir variable in Path() constructor on line 36-38
• Ensures consistent return type across all code paths (function signature declares -> Path)
• Prevents type-related errors when the returned value is used by callers expecting a Path object
• Author tested successfully on Linux with uv venv and LFS downloads work correctly

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The fix is a simple, focused type correction that wraps a string in Path() to match the function's return type annotation. The change has been tested by the author on Linux and resolves the LFS updating issue. No logic changes were made, only type consistency.
• No files require special attention

Important Files Changed

Filename	Overview
dimos/utils/data.py	Fixed return type from string to Path object for virtual environment data directory, ensuring type consistency

Sequence Diagram

sequenceDiagram
    participant User
    participant get_data
    participant _get_data_dir
    participant _get_repo_root
    participant _get_user_data_dir
    participant VirtualEnv as Virtual Environment
    participant LFS as Git LFS

    User->>get_data: Request data file
    get_data->>_get_data_dir: Get data directory path
    _get_data_dir->>_get_repo_root: Get repository root
    _get_repo_root->>_get_user_data_dir: Get user data directory
    
    alt VIRTUAL_ENV is set
        _get_user_data_dir->>VirtualEnv: Check VIRTUAL_ENV variable
        _get_user_data_dir->>_get_user_data_dir: Construct venv-specific path
        Note over _get_user_data_dir: Path(f"{VIRTUAL_ENV}/lib/python{ver}/site-packages/dimos/data")
        _get_user_data_dir-->>_get_repo_root: Return Path object (venv-specific)
    else No VIRTUAL_ENV
        _get_user_data_dir-->>_get_repo_root: Return Path object (platform-specific)
    end
    
    _get_repo_root->>_get_repo_root: Check if repo exists, clone if needed
    _get_repo_root-->>_get_data_dir: Return repo path
    _get_data_dir-->>get_data: Return data directory path
    
    alt File already exists
        get_data-->>User: Return file path
    else File needs LFS pull
        get_data->>LFS: Pull and decompress LFS archive
        LFS-->>get_data: File downloaded
        get_data-->>User: Return file path
    end

Loading

[greptile-apps]

_{No files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}