Small no-dask fixes.

[paul-nechifor]

No description provided.

[greptile-apps]

Greptile Overview

Greptile Summary

This PR completes the dask removal work by implementing attribute proxying and pickling support for the custom Actor/Worker system. The main changes include:

• Worker system enhancements: Added __reduce__ method to Actor for pickle support, implemented functional __getattr__ proxying (replacing the NotImplementedError placeholder), and added getattr request handling in the worker loop
• API consistency: Renamed global_config parameter to cfg across person_follow.py, depth_module.py, and documentation
• Cleanup: Removed unused multiprocessing.resource_sharer import and call from worker_manager.py
• Dependency fix: Constrained langchain to <1.2.4 to avoid compatibility issues

The core functionality replaces dask's attribute access mechanism with a custom IPC-based solution that sends attribute access requests to worker processes.

Confidence Score: 4/5

• This PR is safe to merge with minor risks around attribute serialization
• The changes are well-structured and complete a previously incomplete dask removal. The main concerns are: (1) the new getattr implementation may fail if accessed attributes aren't serializable for IPC, and (2) error handling uses string matching which is fragile. The parameter renaming and cleanup changes are safe. Testing should verify that attribute access works correctly in production scenarios.
• Pay attention to dimos/core/worker.py - verify the getattr implementation works with your actual attribute access patterns

Important Files Changed

Filename	Overview
dimos/core/worker.py	Implements pickling support for Actor and adds getattr proxying, replaces NotImplementedError with functional implementation
dimos/core/worker_manager.py	Removes unused resource_sharer import and call, cleanup change only
pyproject.toml	Restricts langchain version to exclude 1.2.4+, likely due to compatibility issue

Sequence Diagram

sequenceDiagram
    participant C as RPCClient
    participant A as Actor
    participant P as Pipe
    participant W as Worker
    participant M as Module

    C->>A: getattr
    A->>P: send request
    P->>W: forward
    W->>M: getattr
    M-->>W: value
    W->>P: response
    P->>A: forward
    A-->>C: value

Loading

[greptile-apps]

_{7 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

accessing attributes via getattr returns the raw value which may not be serializable for IPC. if attributes like streams (In/Out) or complex objects are accessed, this could cause serialization errors when sending the response back.

[greptile-apps]

string matching on error messages is fragile - if error format changes this will break. consider checking exception type in the worker loop instead, and sending a structured error response with type information.

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}