fix more ruff issues

[paul-nechifor]

No description provided.

[greptile-apps]

Greptile Overview

Greptile Summary

Fixed multiple ruff linting issues across the codebase by addressing 8 different rule violations:

• F401 (unused imports): Removed unused imports and added noqa: F401 comments where imports are needed for side effects (checking module availability)
• F403 (wildcard imports): Replaced from module import * with explicit imports and added __all__ lists
• N812/N813 (import naming): Renamed imports to follow lowercase convention (RxOps → rxops, F → functional)
• N816 (global variable naming): Renamed detectionDB_module to detection_db_module for snake_case consistency
• RUF002 (ambiguous characters): Fixed en-dash in docstring to regular hyphen
• RUF006 (asyncio task references): Stored asyncio.create_task() return values in instance variables to prevent garbage collection
• B023 (loop variable binding): Fixed closure issues by binding loop variables as default parameters

All changes are mechanical linting fixes that improve code quality without altering functionality.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• All changes are automated linting fixes that improve code quality without changing functionality. The fixes address legitimate code quality issues (unused imports, wildcard imports, naming conventions, asyncio task references). No logic changes, no new features, and the changes follow Python best practices.
• No files require special attention

Important Files Changed

Filename	Overview
pyproject.toml	Removed fixed ruff rule codes (B023, F401, F403, N812, N813, N816, RUF002, RUF006) from ignore list
dimos/agents_deprecated/agent.py	Renamed RxOps to rxops for lowercase import naming (N812/N813 fix)
dimos/models/embedding/init.py	Changed try/except pattern to use else clause for conditional exports (F401 fix)
dimos/perception/common/init.py	Replaced wildcard import with explicit imports and all list (F403 fix)
dimos/perception/detection/moduleDB.py	Renamed detectionDB_module to detection_db_module for snake_case naming (N816 fix)
dimos/robot/unitree_webrtc/mujoco_connection.py	Added noqa for mujoco import, fixed cleanup_on_exit to avoid B023 (captured weak_self parameter)
dimos/robot/unitree_webrtc/testing/test_actors.py	Added _tasks set to store asyncio.create_task result with cleanup (RUF006 fix)

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Ruff as Ruff Linter
    participant Code as Codebase
    
    Dev->>Ruff: Run ruff linter
    Ruff->>Code: Detect F401 violations (unused imports)
    Code-->>Ruff: Found unused imports
    Dev->>Code: Remove unused imports or add noqa comments
    
    Ruff->>Code: Detect F403 violations (wildcard imports)
    Code-->>Ruff: Found wildcard imports
    Dev->>Code: Replace with explicit imports + __all__
    
    Ruff->>Code: Detect N812/N813 violations (import naming)
    Code-->>Ruff: Found uppercase imports
    Dev->>Code: Rename to lowercase (RxOps→rxops, F→functional)
    
    Ruff->>Code: Detect N816 violations (variable naming)
    Code-->>Ruff: Found mixedCase globals
    Dev->>Code: Rename to snake_case (detectionDB_module→detection_db_module)
    
    Ruff->>Code: Detect RUF006 violations (asyncio tasks)
    Code-->>Ruff: Found unreferenced create_task calls
    Dev->>Code: Store task references in instance variables
    
    Ruff->>Code: Detect B023 violations (loop binding)
    Code-->>Ruff: Found unbound loop variables
    Dev->>Code: Bind variables as default parameters
    
    Ruff->>Code: Detect RUF002 violations (ambiguous chars)
    Code-->>Ruff: Found en-dash in docstring
    Dev->>Code: Replace with regular hyphen
    
    Dev->>Ruff: Update pyproject.toml ignore list
    Ruff->>Code: Re-run linter
    Code-->>Ruff: All violations resolved
    Ruff-->>Dev: Linting passed ✓

Loading

[greptile-apps]

_{No files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

_{No files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[spomichter]

why are we doing this

[paul-nechifor]

why are we doing this

@spomichter Many of the ruff checks are disabled. I've fixed the ones with very few issues. The biggest change is F401 which auto removes unused imports.

[leshy]

merging this, just automatic linting stuff stash, pretty standard, no dev friction