Skip to content

Add initital codeowners file#6990

Merged
mathias-lang-sociomantic merged 1 commit intodlang:masterfrom
wilzbach:add-initial-codeowners
Dec 5, 2017
Merged

Add initital codeowners file#6990
mathias-lang-sociomantic merged 1 commit intodlang:masterfrom
wilzbach:add-initial-codeowners

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Jul 12, 2017

Similarly to dlang/phobos#5573

Code owners are automatically requested for review when someone opens a pull request that modifies code that they own. When someone with admin permissions has enabled required reviews, they can optionally require approval from a code owner.

Moreover, it's a simple plain-text format:

A CODEOWNERS file uses a pattern that follows the same rules used in gitignore files. The pattern is followed by one or more GitHub usernames or team names using the standard @username or @org/team-name format.

For more information, the help page goes into more details.

I tried to use some insights from @MartinNowak's git blame analyzer, but this isn't perfect and your feedback and input would be very welcome: what are files in the DMD codebase that you feel comfortable with? Are there mappings that I add that don't reflect the status quo?

We had some troubles with GitHub at Phobos, but here's an example on how it will look in live.

CC @dlang/team-dmd @Geod24 @LemonBoy @kinke @redstar @rainers @mathias-lang-sociomantic @thewilsonator @luismarques @JohanEngelen and all other awesome DMD contributors

(I will wait a few days and if you don't confirm that you are ok with being pinged on a PR, I will remove you from the file for now).

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@thewilsonator
Copy link
Contributor

Awesome.

@redstar
Copy link
Contributor

redstar commented Jul 13, 2017

Many thanks for doing this!

@rainers
Copy link
Member

rainers commented Jul 13, 2017

Fine with me. According to the file headers, you can assign src/ddmd/vcbuild/, src/ddmd/root/longdouble. and src/ddmd/backend/varstats.* to me.

BTW: s/GiHub/GitHub/ ?

CODEOWNERS Outdated
src/ddmd/mars.d @MartinNowak @mathias-lang-sociomantic @rainers @UplinkCoder @WalterBright
src/ddmd/objc* @JacobCarlborg
src/ddmd/permissivevisitor.d @RazvanN7
src/ddmd/target.d @MartinNowak
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the creator of this module, I insist being notified of changes. ☺️

src/ddmd/utf.d @luismarques

# GiHub's implementation of the CODEOWNERS format is buggy, so this might not work
src/ddmd/*.h @ibuclaw
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, I'm maintaining the c++ branch anyway.

src/ddmd/builtin.d @klickvebot @WalterBright
src/ddmd/cond.d @mathias-lang-sociomantic
src/ddmd/console.d @CyberShadow
src/ddmd/cppmangle.d @ibuclaw
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to also include @yebblies here, but I'll let him confirm that.

@wilzbach wilzbach force-pushed the add-initial-codeowners branch from 53f31ca to e3ede5c Compare December 1, 2017 15:34
@wilzbach
Copy link
Contributor Author

wilzbach commented Dec 1, 2017

Ok I finally found time to get back to this. Anyone still missing on this file or is it good to go as an initial version? (It can always be modified later)

@JinShil
Copy link
Contributor

JinShil commented Dec 1, 2017

Is @yebblies still active with dlang? I haven't seen anything from him in a while.

@wilzbach
Copy link
Contributor Author

wilzbach commented Dec 5, 2017

Is @yebblies still active with dlang? I haven't seen anything from him in a while.

Same here :/
Should I remove him from this file or should we simply take this as an initial version and gradually improve it?
While some contributes will fade, hopefully new contributors will come, so I expect the CODEOWNERS file to be updated from time to time.
For example, you might want to add yourself to the file ;-)

@andralex
Copy link
Member

andralex commented Dec 5, 2017

Remove @yebblies and add him when he shows up. We should track a 3 months long moving window or so.

@JinShil
Copy link
Contributor

JinShil commented Dec 5, 2017

For example, you might want to add yourself to the file ;-)

I think I'm still earning my wings. When I feel confident, I'll submit a PR.

@wilzbach wilzbach force-pushed the add-initial-codeowners branch from 19a77db to 09990bd Compare December 5, 2017 04:18
@wilzbach
Copy link
Contributor Author

wilzbach commented Dec 5, 2017

Remove @yebblies and add him when he shows up.

Ok. Done.

We should track a 3 months long moving window or so.

Good idea, but remembering to update the CODEOWNER files every month could be tricky.

@mathias-lang-sociomantic mathias-lang-sociomantic merged commit 248b456 into dlang:master Dec 5, 2017
@wilzbach wilzbach deleted the add-initial-codeowners branch March 13, 2018 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants