Add initital codeowners file#6990
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
Awesome. |
|
Many thanks for doing this! |
|
Fine with me. According to the file headers, you can assign src/ddmd/vcbuild/, src/ddmd/root/longdouble. and src/ddmd/backend/varstats.* to me. BTW: s/GiHub/GitHub/ ? |
CODEOWNERS
Outdated
| src/ddmd/mars.d @MartinNowak @mathias-lang-sociomantic @rainers @UplinkCoder @WalterBright | ||
| src/ddmd/objc* @JacobCarlborg | ||
| src/ddmd/permissivevisitor.d @RazvanN7 | ||
| src/ddmd/target.d @MartinNowak |
There was a problem hiding this comment.
As the creator of this module, I insist being notified of changes.
| src/ddmd/utf.d @luismarques | ||
|
|
||
| # GiHub's implementation of the CODEOWNERS format is buggy, so this might not work | ||
| src/ddmd/*.h @ibuclaw |
There was a problem hiding this comment.
This is fine, I'm maintaining the c++ branch anyway.
| src/ddmd/builtin.d @klickvebot @WalterBright | ||
| src/ddmd/cond.d @mathias-lang-sociomantic | ||
| src/ddmd/console.d @CyberShadow | ||
| src/ddmd/cppmangle.d @ibuclaw |
There was a problem hiding this comment.
I would suggest to also include @yebblies here, but I'll let him confirm that.
53f31ca to
e3ede5c
Compare
|
Ok I finally found time to get back to this. Anyone still missing on this file or is it good to go as an initial version? (It can always be modified later) |
e3ede5c to
19a77db
Compare
|
Is @yebblies still active with dlang? I haven't seen anything from him in a while. |
Same here :/ |
|
Remove @yebblies and add him when he shows up. We should track a 3 months long moving window or so. |
I think I'm still earning my wings. When I feel confident, I'll submit a PR. |
19a77db to
09990bd
Compare
Ok. Done.
Good idea, but remembering to update the CODEOWNER files every month could be tricky. |
Similarly to dlang/phobos#5573
Moreover, it's a simple plain-text format:
For more information, the help page goes into more details.
I tried to use some insights from @MartinNowak's git blame analyzer, but this isn't perfect and your feedback and input would be very welcome: what are files in the DMD codebase that you feel comfortable with? Are there mappings that I add that don't reflect the status quo?
We had some troubles with GitHub at Phobos, but here's an example on how it will look in live.
CC @dlang/team-dmd @Geod24 @LemonBoy @kinke @redstar @rainers @mathias-lang-sociomantic @thewilsonator @luismarques @JohanEngelen and all other awesome DMD contributors
(I will wait a few days and if you don't confirm that you are ok with being pinged on a PR, I will remove you from the file for now).