Add initital codeowners file by wilzbach · Pull Request #1870 · dlang/druntime

wilzbach · 2017-07-12T19:01:44Z

Code owners are automatically requested for review when someone opens a pull request that modifies code that they own. When someone with admin permissions has enabled required reviews, they can optionally require approval from a code owner.

Moreover, it's a simple plain-text format:

A CODEOWNERS file uses a pattern that follows the same rules used in gitignore files. The pattern is followed by one or more GitHub usernames or team names using the standard @username or @org/team-name format.

For more information, the help page goes into more details.

I tried to use some insights from @MartinNowak's git blame analyzer, but this isn't perfect and your feedback and input would be very welcome: what are files in the druntime codebase that you feel comfortable with? Are there mappings that I added that don't reflect the status quo?

We had some troubles with GitHub at Phobos, but here's an example on how it will look in live.

@dlang/team-druntime @Abscissa @aG0aep6G @andralex @atilaneves @braddr @Burgos @Calrama @CyberShadow @Darredevil @deadalnix @DmitryOlshansky @etcimon @ibuclaw @JackStouffer @JacobCarlborg @jmdavis @joakim-noah @jpf91 @klickverbot @leandro-lucarella-sociomantic @MarcoLeisse @MartinNowak @mathias-lang-sociomantic @nrTQgc @rainers @redstar @schveiguy @tsbockman @WalterBright @wilzbach @ZombineDev and other awesome druntime contributors!

(I will wait a few days and if you don't confirm that you are ok with being pinged on a PR, I will remove you from the file for now).

dlang-bot · 2017-07-12T19:01:46Z

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Burgos · 2017-07-12T19:11:59Z

Hello and thanks for the initiative! Since I spent a bunch of time looking and debugging src/rt/sections_elf_shared.d, src/rt/dwarfeh.d, you can add me there as well.

joakim-noah · 2017-07-12T19:25:17Z

Fine by me.

tsbockman · 2017-07-12T19:45:57Z

Sure, you can list me for core.bitop if you want.

MoritzMaxeiner · 2017-07-12T20:36:34Z

I'm okay with it.

redstar · 2017-07-13T04:16:23Z

Very nice. I'm ok with it.

rainers · 2017-07-13T06:01:29Z

Fine with me.

schveiguy · 2017-07-13T12:33:57Z

These handles are incorrect, should be fixed: @mleise, @jacob-carlborg

Fine by me, thanks!

jacob-carlborg · 2017-07-13T13:50:45Z

@wilzbach you can put me on src/rt/sections_osx*, src/rt/osx_tls.c and basically anything macOS or Apple related.

PetarKirov · 2017-07-13T17:54:45Z

CODEOWNERS

+src/core/simd.d @WalterBright @MartinNowak
+src/core/stdc/* @schveiguy
+src/core/stdcpp/* @WalterBright @Darredevil
+src/core/sync/* @MartinNowak @mathias-lang-sociomantic @WalterBright


+1 for src/core/sync/*

PetarKirov · 2017-07-13T18:00:02Z

CODEOWNERS

+src/core/sys/posix/* @CyberShadow @MartinNowak @joakim-noah @redstar
+src/core/sys/solaris/* @redstar
+src/core/sys/windows/* @CyberShadow
+src/core/thread.d @MartinNowak @ZombineDev @Burgos @jpf91


Can you move me at the end of the list? There much more knowledgeable people than me for this part of the codebase.

PetarKirov · 2017-07-13T18:05:21Z

CODEOWNERS

+src/core/demangle.d @WalterBright @MartinNowak @rainers @ibuclaw
+src/core/exception.d @MartinNowak @WalterBright @jmdavis @CyberShadow
+src/core/internal @MartinNowak @schveiguy
+src/core/math.d @braddr @redstar


s/braddr/ibuclaw/

I'm ok being a replacement for braddr.

mleise · 2017-07-13T18:40:57Z

Thanks @schveiguy for giving the correct handles. I didn't design any of the functionality of core.cpuid, but I am responsible for the GDC port. Looks fine to me.

ibuclaw · 2017-07-13T19:05:15Z

CODEOWNERS

+src/core/math.d @braddr @redstar
+src/core/runtime.d @MartinNowak @Abscissa
+src/core/simd.d @WalterBright @MartinNowak
+src/core/stdc/* @schveiguy


Maybe there should be at least two reviewers assigned per section? (I don't mind being pinged for any C binding-related PRs).

aG0aep6G · 2017-07-13T21:56:39Z

CODEOWNERS

+
+src/checkedint.d @redstar @andralex @JackStouffer
+
+src/core/atomic.d @WalterBright @aG0aep6G


I have an interest in core.atomic, but I'm far from being an expert on the subject, nor am I particularly familiar with the code. I made like two PRs for it.

dnadlinger · 2017-07-13T22:15:53Z

CODEOWNERS

+
+src/object.d @andralex @MartinNowak
+
+src/rt/deh_win32.d @leandro-lucarella-sociomantic @klickverbot


Should be @WalterBright, not me. This is the DMD-specific Win32 SEH implementation.

Me neither, I haven't use Windows in the past 20 years or more :)

wilzbach · 2017-12-01T15:32:15Z

Ok I finally found time to get back to this. Anyone still missing on this file or is it good to go as an initial version? (It can always be modified later)

mathias-lang-sociomantic · 2017-12-01T15:34:21Z

Could you list my personal account (@Geod24 ) along my Sociomantic one ? Thanks.

wilzbach · 2017-12-01T15:36:34Z

Could you list my personal account (@Geod24 ) along my Sociomantic one ? Thanks.

Sure. Done ;-)
I also changed it for the respective DMD PR: dlang/dmd#6990

leandro-lucarella-sociomantic · 2017-08-01T17:48:59Z

CODEOWNERS

+
+src/object.d @andralex @MartinNowak
+
+src/rt/deh_win32.d @leandro-lucarella-sociomantic @klickverbot


Me neither, I haven't use Windows in the past 20 years or more :)

leandro-lucarella-sociomantic · 2017-12-01T15:52:23Z

CODEOWNERS

+
+src/object.d @andralex @MartinNowak
+
+src/rt/deh_win32.d @WalterBright @leandro-lucarella-sociomantic


Please no, I don't know anything about this :)

Repeat after the pantomime - Oh yes he does! :)

jacob-carlborg · 2017-12-01T16:31:07Z

CODEOWNERS

+src/core/stdcpp/* @WalterBright @Darredevil
+src/core/sync/* @MartinNowak @mathias-lang-sociomantic @Geod24 @WalterBright @ZombineDev
+src/core/sys/bionic/* @joakim-noah
+src/core/sys/darwin/* @klickverbot


I think the names for src/core/sys/darwin/* and src/core/sys/osx/* should be the same.

ibuclaw · 2017-12-03T15:53:20Z

CODEOWNERS

+
+src/core/atomic.d @WalterBright
+src/core/attribute.d @jaoc-carlborg
+src/core/bitop.d @schveiguy @tsbockman @mathias-lang-sociomantic @Geod24


@mathias-lang-sociomantic - did you ask for yourself added twice here? (Have I given away too much information by suggesting you have a second identity?)

Yes he did:

Could you list my personal account (@Geod24 ) along my Sociomantic one ? Thanks.

So going undercover now would require a third account ;-)

ibuclaw · 2017-12-03T15:54:04Z

CODEOWNERS

+src/checkedint.d @redstar @andralex @JackStouffer
+
+src/core/atomic.d @WalterBright
+src/core/attribute.d @jaoc-carlborg


Misspelt name here. You also misspelt it as jacob-carbord also.

ibuclaw · 2017-12-03T15:56:46Z

CODEOWNERS

+src/rt/sections_win* @rainers
+src/rt/sections_osx* @jacob-carlbord
+src/rt/osx_tls.c* @jacob-carlbord
+src/rt/sections_elf_shared * @Burgos


Misplaced *

ibuclaw · 2017-12-03T15:58:14Z

CODEOWNERS

+src/core/atomic.d @WalterBright
+src/core/attribute.d @jaoc-carlborg
+src/core/bitop.d @schveiguy @tsbockman @mathias-lang-sociomantic @Geod24
+src/core/cpuid.d @WalterBright @mleise @JackStouffer


Maybe add myself here in place of @mleise? I assume that he shows up as he added GDC support.

ibuclaw · 2017-12-03T16:00:20Z

CODEOWNERS

+src/rt/sections_android.d @joakim-noah
+src/rt/sections_win* @rainers
+src/rt/sections_osx* @jacob-carlbord
+src/rt/osx_tls.c* @jacob-carlbord


I think this matcher is wrong (remove the *).

ibuclaw · 2017-12-03T16:01:17Z

CODEOWNERS

+
+src/checkedint.d @redstar @andralex @JackStouffer
+
+src/core/atomic.d @WalterBright


You can add myself here as well.

ibuclaw · 2017-12-03T16:02:38Z

Made one last sweep, everything looks fine except for noted mistakes @wilzbach.

wilzbach · 2017-12-03T17:24:49Z

Made one last sweep, everything looks fine except for noted mistakes @wilzbach.

Thanks a lot.

ibuclaw · 2017-12-03T21:16:48Z

CODEOWNERS

+src/core/time.d @jmdavis @schveiguy @CyberShadow
+
+src/etc* @deadalnix @MartinNowak
+src/gc* @rainers @DmitryOlshansky @MartinNowak @leandro-lucarella-sociomantic


This will match subdirectories right?

ibuclaw

I'll give it a tick, will give it a short while to let others give feedback.

andralex · 2017-12-04T19:28:38Z

I'll merge, we can change later as needed.

PetarKirov reviewed Jul 13, 2017

View reviewed changes

ibuclaw reviewed Jul 13, 2017

View reviewed changes

aG0aep6G reviewed Jul 13, 2017

View reviewed changes

dnadlinger reviewed Jul 13, 2017

View reviewed changes

wilzbach force-pushed the add-initial-codeowners branch from 8a785c9 to 2635b8e Compare December 1, 2017 15:31

wilzbach force-pushed the add-initial-codeowners branch from 2635b8e to b6a3110 Compare December 1, 2017 15:35

andralex approved these changes Dec 1, 2017

View reviewed changes

leandro-lucarella-sociomantic reviewed Dec 1, 2017

View reviewed changes

jacob-carlborg reviewed Dec 1, 2017

View reviewed changes

ibuclaw reviewed Dec 3, 2017

View reviewed changes

CODEOWNERS Outdated

src/checkedint.d @redstar @andralex @JackStouffer

src/core/atomic.d @WalterBright

Copy link

Member

ibuclaw Dec 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add myself here as well.

Add initital codeowners file

ac9f4a6

wilzbach force-pushed the add-initial-codeowners branch from b6a3110 to ac9f4a6 Compare December 3, 2017 17:24

ibuclaw reviewed Dec 3, 2017

View reviewed changes

ibuclaw approved these changes Dec 3, 2017

View reviewed changes

andralex merged commit 35300ba into dlang:master Dec 4, 2017


		src/checkedint.d @redstar @andralex @JackStouffer

		src/core/atomic.d @WalterBright @aG0aep6G


		src/object.d @andralex @MartinNowak

		src/rt/deh_win32.d @leandro-lucarella-sociomantic @klickverbot


		src/object.d @andralex @MartinNowak

		src/rt/deh_win32.d @WalterBright @leandro-lucarella-sociomantic


		src/checkedint.d @redstar @andralex @JackStouffer

		src/core/atomic.d @WalterBright

Uh oh!

Conversation

wilzbach commented Jul 12, 2017

Uh oh!

dlang-bot commented Jul 12, 2017

Bugzilla references

Uh oh!

Burgos commented Jul 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joakim-noah commented Jul 12, 2017

Uh oh!

tsbockman commented Jul 12, 2017

Uh oh!

MoritzMaxeiner commented Jul 12, 2017

Uh oh!

redstar commented Jul 13, 2017

Uh oh!

rainers commented Jul 13, 2017

Uh oh!

schveiguy commented Jul 13, 2017

Uh oh!

jacob-carlborg commented Jul 13, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mleise commented Jul 13, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dnadlinger Jul 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wilzbach commented Dec 1, 2017

Uh oh!

mathias-lang-sociomantic commented Dec 1, 2017

Uh oh!

wilzbach commented Dec 1, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ibuclaw Dec 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ibuclaw Dec 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ibuclaw commented Dec 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wilzbach commented Dec 3, 2017

Burgos commented Jul 12, 2017 •

edited

Loading

dnadlinger Jul 13, 2017 •

edited

Loading

ibuclaw Dec 3, 2017 •

edited

Loading

ibuclaw Dec 3, 2017 •

edited

Loading

ibuclaw commented Dec 3, 2017 •

edited

Loading