Skip to content

CODEOWNERS: Add whitespace after # comments due to GitHub bug#5604

Merged
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:codeowners-whitespace
Jul 12, 2017
Merged

CODEOWNERS: Add whitespace after # comments due to GitHub bug#5604
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:codeowners-whitespace

Conversation

@wilzbach
Copy link
Contributor

According to the friendly GitHub support:

We currently have a bug with CODEOWNERS files where commenting out a line will stop the feature working entirely. If you remove any lines with a # it should start to work correctly again. Alternatively - since you have a lot of commented out lines in that file - you can add a space after the # characters which should also fix the issue.

Formatting it like this should fix the issue, with the space between the # and the filepath:

#abc <- Will break the whole file x_x
# abc <- should be good!

I hope this helps ...

According to the GitHub support:
We currently have a bug with CODEOWNERS files where commenting out a line
will stop the feature working entirely.
If you remove any lines with a # it should start to work correctly again.
Alternatively - since you have a lot of commented out lines in that file -
you can add a space after the # characters which should also fix the issue.
@wilzbach wilzbach added Infrastructure:automation Review:Trivial typos, formatting, comments labels Jul 12, 2017
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@dlang-bot dlang-bot merged commit 72e93db into dlang:master Jul 12, 2017
@wilzbach wilzbach deleted the codeowners-whitespace branch December 11, 2017 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants