std.math: Implement floor for ibmExtended reals.#5822
Merged
dlang-bot merged 1 commit intodlang:masterfrom Apr 6, 2018
Merged
Conversation
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#5822" |
ibuclaw
force-pushed
the
ppcfloor
branch
2 times, most recently
from
47a173d to
ac5b074
Compare
Member
|
ping reviewers: this PR has been rotting here for far too long. We need someone familiar with numerics to take a look! |
Member
|
ping @klickverbot |
Member
Author
|
@redstar - Oh, and this you may be interested in also. |
Member
|
Needs a rebase after #5823 is merged. |
n8sh
approved these changes
Mar 27, 2018
Contributor
|
Merging based on qualified review |
wilzbach
added
the
Merge:72h no objection -> merge
Member
Contributor
|
Oh I was just marking the PR, s.t. I didn't forget to rebase it later (done that now). |
Member
Author
|
@wilzbach didn't quite rebase it correctly, now I'm back I've fixed that. ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a slight extension of #5820. Tested against PPC64/LE.
https://github.com/dlang/phobos/pull/5822/files?w=1