Skip to content

std.math: fix feqrel for ibmExtended floats.#6275

Merged
dlang-bot merged 1 commit intodlang:masterfrom
redstar:feqrel
Mar 13, 2018
Merged

std.math: fix feqrel for ibmExtended floats.#6275
dlang-bot merged 1 commit intodlang:masterfrom
redstar:feqrel

Conversation

@redstar
Copy link
Contributor

@redstar redstar commented Mar 13, 2018

cast(double*)(&x)[MANTISSA_MSB] is of type double*. Moving the
opening parenthesis gives the right result.

cast(double*)(&x)[MANTISSA_MSB] is of type double*. Moving the
opening parenthesis gives the right result.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @redstar! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@ibuclaw
Copy link
Member

ibuclaw commented Mar 13, 2018

@redstar #5822 and #5823

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume ibmExtended isn't tested by the CIs?

@dlang-bot dlang-bot merged commit d51fd2a into dlang:master Mar 13, 2018
@ibuclaw
Copy link
Member

ibuclaw commented Mar 13, 2018

@wilzbach I have a cross builder for ppc64le, haven't managed to get testsuite running yet, it would have to be in under qemu unless someone has hardware to run on. =)

@redstar
Copy link
Contributor Author

redstar commented Mar 14, 2018

@wilzbach My development version of LDC uses ibmExtended right now. Nothing is committed yet and therefore not visible on the buildbot (http://buildbot.ldc-developers.org/waterfall).

@redstar redstar deleted the feqrel branch March 14, 2018 06:21
@ibuclaw
Copy link
Member

ibuclaw commented Mar 14, 2018

Nice. I've disabled mine until the hosting provider gets more servers in. :-(

https://buildbot.dgnu.org/#/waterfall

@wilzbach
Copy link
Contributor

Nice. I've disabled mine until the hosting provider gets more servers in. :-(

@ibuclaw FYI: if money is the bottleneck, Laeeth recently offered to sponsor a few ARM build servers for LDC:

How much RAM is needed to compile LDC on ARM? If more scaleway build servers would help, I can easily contribute up to 10 right now - in which case I would just sign up and give you or him the login details.

https://www.scaleway.com/pricing/

It doesn't make any direct difference to me commercially for the foreseeable future. But I'd like to know D runs on Android and Linux on ARM. Currently we use iOS devices for security reasons, but China is on Android so it would be nice to move to some kind of hardened Android (we are looking into Copperhead). And maybe with the spec execution problems, future generations of ARM will become more appealing than Intel for servers.

I'm not sure whether this offer would apply to GDC or other architectures like PPC64 too, but otherwise the DLF might be able to help out monetary-wise too.

@ibuclaw
Copy link
Member

ibuclaw commented Mar 14, 2018

Cost isn't a problem. Scaleway have a lack of servers is the bottleneck. Also ping @andralex on slack and ask about D foundation funding for servers.

@redstar
Copy link
Contributor Author

redstar commented Mar 14, 2018

@ibuclaw Is this the new buildbot ui? Updating from 0.8.x to 1.x is next on my agenda...

@ibuclaw
Copy link
Member

ibuclaw commented Mar 15, 2018

@redstar yes it is the new UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants