std.math: fix feqrel for ibmExtended floats.#6275
Conversation
cast(double*)(&x)[MANTISSA_MSB] is of type double*. Moving the opening parenthesis gives the right result.
|
Thanks for your pull request and interest in making D better, @redstar! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
wilzbach
left a comment
There was a problem hiding this comment.
I assume ibmExtended isn't tested by the CIs?
|
@wilzbach I have a cross builder for ppc64le, haven't managed to get testsuite running yet, it would have to be in under qemu unless someone has hardware to run on. =) |
|
@wilzbach My development version of LDC uses |
|
Nice. I've disabled mine until the hosting provider gets more servers in. :-( |
@ibuclaw FYI: if money is the bottleneck, Laeeth recently offered to sponsor a few ARM build servers for LDC:
I'm not sure whether this offer would apply to GDC or other architectures like PPC64 too, but otherwise the DLF might be able to help out monetary-wise too. |
|
Cost isn't a problem. Scaleway have a lack of servers is the bottleneck. Also ping @andralex on slack and ask about D foundation funding for servers. |
|
@ibuclaw Is this the new buildbot ui? Updating from 0.8.x to 1.x is next on my agenda... |
|
@redstar yes it is the new UI. |
cast(double*)(&x)[MANTISSA_MSB]is of typedouble*. Moving theopening parenthesis gives the right result.