std.math: Use DOUBLEPAIR_MSB/LSB for accessing high/low parts of ibmExtended format#5823
Merged
dlang-bot merged 1 commit intodlang:masterfrom Mar 26, 2018
Merged
std.math: Use DOUBLEPAIR_MSB/LSB for accessing high/low parts of ibmExtended format#5823dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
Member
Author
|
Maybe its time to resurrect #4336 |
Contributor
|
Very nice - I found this, too. I will have a closer look this evening. One point: you are enabling doubledouble support on little endian. This should also be reflected in the version check at the beginning of the file (https://github.com/dlang/phobos/blob/master/std/math.d#L233). |
Member
Author
Contributor
|
Ok, this is the simple approach. :-) Looks good to me. There are no overlooked instance, so it should work out of the box. |
Member
Author
|
Rebased. |
PetarKirov
approved these changes
Mar 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A continuation of #5822 (or a prelude, works both ways).
When running the unittests for PPC64/LE, found many failures due to it checking the wrong part (
MANTISSA_MSBvalue is the least significant index onLittleEndian).Fixed places where Big/Little endian would otherwise differ, but actually should do the same thing.