Skip to content

std.format: Add unittests for %g (step 2).#7815

Merged
dlang-bot merged 1 commit intodlang:masterfrom
berni44:format_add_g_unittests
Mar 1, 2021
Merged

std.format: Add unittests for %g (step 2).#7815
dlang-bot merged 1 commit intodlang:masterfrom
berni44:format_add_g_unittests

Conversation

@berni44
Copy link
Contributor

@berni44 berni44 commented Mar 1, 2021

Followup on #7810.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7815"

@thewilsonator
Copy link
Contributor

Why are so many tests comments out?

@berni44
Copy link
Contributor Author

berni44 commented Mar 1, 2021

Why are so many tests comments out?

They don't work yet. %g isn't just selecting between %e and %f. There are other changes needed too: Mainly, precision has a different meaning and trailing zeros are removed. So the unittests are the roadmap to follow. The idea is to make them work step by step.

@dlang-bot dlang-bot merged commit 1100b94 into dlang:master Mar 1, 2021
@berni44 berni44 deleted the format_add_g_unittests branch April 28, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants