Skip to content

std.format: Add %g (step 3): Add template parameter to printFloatE/F.#7816

Merged
dlang-bot merged 1 commit intodlang:masterfrom
berni44:format_add_g_call_ef
Mar 1, 2021
Merged

std.format: Add %g (step 3): Add template parameter to printFloatE/F.#7816
dlang-bot merged 1 commit intodlang:masterfrom
berni44:format_add_g_call_ef

Conversation

@berni44
Copy link
Contributor

@berni44 berni44 commented Mar 1, 2021

Another followup on #7810. Can be merged independently of #7815.

Precision is already adjusted in printFloatG so it is not necessary to repeat this in printFloatE/F.

See #7804 for the background.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7816"

@RazvanN7
Copy link
Collaborator

RazvanN7 commented Mar 1, 2021

I think it would be useful to include in the description of these PRs the initial (closed) PR so that other reviewers have a chance to understand the broader picture. I will merge this for now, but anyone else reviewing this will not understand what the point is.

@dlang-bot dlang-bot merged commit 0b16c92 into dlang:master Mar 1, 2021
@berni44
Copy link
Contributor Author

berni44 commented Mar 1, 2021

I think it would be useful to include in the description of these PRs the initial (closed) PR so that other reviewers have a change to understand the broader picture. I will merge this for now, but anyone else reviewing this will not understand what the point is.

Added the link to the initial comment. Thanks for pointing this out.

@berni44 berni44 deleted the format_add_g_call_ef branch April 28, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants