Fix 'make lint' build issue for python2 users#411
Closed
apeforest wants to merge 12 commits intodmlc:masterfrom
apeforest:master
Closed
Fix 'make lint' build issue for python2 users#411apeforest wants to merge 12 commits intodmlc:masterfrom apeforest:master
apeforest wants to merge 12 commits intodmlc:masterfrom
apeforest:master
Conversation
Fix the 'make lint' build error for python2 users
szha
reviewed
Jun 19, 2018
Member
szha
left a comment
szha
left a comment
There was a problem hiding this comment.
This change won't enable pylint for py2 in mxnet. Changes will need to be made there too.
Fix build error due to missing pip(2) in travis package
Member
|
@szha I would recommend only enable pylint for python3 from this point on, as python2 is going to be deprecated by major packages in 2019 |
CMAKE_C_FLAGS are for compiling C files, so you need to set the CMAKE_CXX_FLAGS variable instead. This patch fixes a compilation issue when using clang as the default C compiler.
* add support for int64 in CSVParser * Rename ParserFactorReg to use int32/int64
Contributor
Author
|
This has been fixed by dmlc/mshadow#340. Close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An earlier commit (b744643) replaced pip to pip3 in the .travis.yml. While it made pip3 work well it broke the 'make lint' command for python2 users. I made a change in .travis.yml to support multiple python versions. This practice is borrowed from cpplint package (https://github.com/cpplint/cpplint/blob/master/.travis.yml).
Verified the fix locally by installing cpplint and pylint using pip(2).