2128 split drive not handling relative paths #2181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They should not ever be relative. Signed-off-by: Mazz Mosley <mazz@houseofmnowster.com>
splitdrive doesn't handle relative paths, so if volume_path contains a relative path, we handle that differently and manually set drive to ''. Signed-off-by: Mazz Mosley <mazz@houseofmnowster.com>
|
LGTM |
Author
There was a problem hiding this comment.
Because container_path should never be relative, so we don't need to call expanduser on it. @aanand spotted it last time when I was working through understanding the paths situation.
There was a problem hiding this comment.
I guess it would expand to the wrong path, that's true. We added this in 1.4.0, so we should probably call this out in the release notes as a bug fix.
dnephin
added a commit
that referenced
this pull request
Oct 14, 2015
…relative-paths 2128 split drive not handling relative paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #2128