Update Chrome driver#33019
Conversation
ghost
added
the
area-infrastructure
| "drivers": { | ||
| "chrome": { | ||
| "version" : "91.0.4472.77" | ||
| "version" : "91.0.4472.19" |
There was a problem hiding this comment.
Usually we try to match this version and the SeleniumWebDriverChromeDriverVersion: https://www.nuget.org/packages/Selenium.WebDriver.ChromeDriver/91.0.4472.1900-beta at https://github.com/dotnet/aspnetcore/blob/main/eng/Versions.props#L250.
There was a problem hiding this comment.
It's non-obvious what the relationship is between those two things, and I'd like to unblock builds
There was a problem hiding this comment.
The relationship is mainly to the version of Chrome installed. Kestrel's Interop.FunctionalTests.csproj should fail w/ the current version or will real soon now. Plz fix if possible though separate PR may be fine.
There was a problem hiding this comment.
Someone will need to add the package to the dotnet-public feed
|
/backport to release/5.0 |
|
Started backporting to release/5.0: https://github.com/dotnet/aspnetcore/actions/runs/883489688 |
|
@dougbu backporting to release/5.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Update Chrome driver
Using index info to reconstruct a base tree...
M eng/Versions.props
Falling back to patching base and 3-way merge...
Auto-merging eng/Versions.props
CONFLICT (content): Merge conflict in eng/Versions.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update Chrome driver
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
Well, that didn't work and I'm working on other manual backports. Can you handle this one @BrennanConroy❔ |
* [release/5.9] Update branding to v5.0.8 - disable baseline validation * [release/5.0] Update cert that became valid and broke tests - backport of 2e20bab (#32812) - dupe of #33033 * Update cert to not be valid for 50 years * Make cert valid in 10 years * Delete unused copy of certs, update right one * Skip test for now * [release/5.0] Update Chrome driver - backport of e7b5aa6 (#33019) * [release/5.0] Update selenium chrome driver - backport of af96aba (#33043)
3 participants
No description provided.