[release/5.0] Clean out Ubuntu 16.04 testing#33103
Merged
Merged
Conversation
- cherry-pick of #32894 * Clean out Ubuntu 16.04 testing - use Ubuntu 18.04 agents for testing in Docker containers on Helix - also move to supported version of Fedora * Support added `msbuild` arguments in RunHelix.ps1 - bring in part of 0551cef (#32554) - no reason to maintain major differences from main version of script - slight difference is we still test on Windows.10.Amd64.Open by default here nits: - clean up a few old mentions of Centos and Fedora testing - fix `%(Platform)` metadata for OSX `@(HelixAvailableTargetQueue)` items - pick up a small bit of the master -> main renaming improvements - use `[switch]` instead of `[bool]` in RunHelix.ps1 parameters
Contributor
Author
|
@HaoK @BrennanConroy I'm duplicating #33033 and backporting both #33019 and #33043 here to see if the fixes are enough to get 5.0.x builds working again. I'll probably move the #33019 and #33043 commits into #33033 if this works because the Ubuntu 16.04 removal shouldn't be necessary to fix our builds. Plan is to merge the fixes for build breaks together w/ 5.0.8 branding and keep other bits separate. @dotnet/aspnet-build this can be ignored for now but /fyi |
Pilchie
added
the
area-infrastructure
dougbu
added
the
ask-mode
Contributor
Author
|
Note to reviewers: Only the first commit will go in separately (and after) #33033. That's all to review here. |
dougbu
added
ask-mode
dougbu
changed the title
HaoK
approved these changes
May 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.