Skip to content

[release/5.0] Update cert that became valid and broke tests#33033

Closed
github-actions[bot] wants to merge 6 commits into
release/5.0from
backport/pr-32812-to-release/5.0
Closed

[release/5.0] Update cert that became valid and broke tests#33033
github-actions[bot] wants to merge 6 commits into
release/5.0from
backport/pr-32812-to-release/5.0

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 26, 2021

Backport of #32812 to release/5.0

/cc @HaoK

Customer Impact

Testing

Risk

@github-actions github-actions Bot requested a review from Tratcher as a code owner May 26, 2021 09:47
@Pilchie Pilchie added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label May 26, 2021
@HaoK
Copy link
Copy Markdown
Member

HaoK commented May 27, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented May 27, 2021

Azure Pipelines successfully started running 2 pipeline(s).

dougbu
dougbu approved these changes May 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but failures seem consistent. PR may need something more…

@dougbu dougbu added this to the 5.0.8 milestone May 27, 2021
@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label May 27, 2021
@dougbu
Copy link
Copy Markdown
Contributor

dougbu commented May 27, 2021

Another one for the @dotnet/aspnet-build team to get in. /fyi @dotnet/aspnet-build https://github.com/dotnet/aspnetcore/pulls/app%2Fgithub-actions shows all PRs the backport bot opened.

@Pilchie I marked this one as tell-mode too

@dougbu dougbu mentioned this pull request May 27, 2021
Merged
@HaoK
Copy link
Copy Markdown
Member

HaoK commented May 27, 2021

Selenium ChromeDriver version looks to be the issue in release/5.0 for the other failures

System.InvalidOperationException : Couldn't create a Selenium remote driver client. The server is irresponsive\r\n---- System.InvalidOperationException : session not created: This version of ChromeDriver only supports Chrome version 89\nCurrent browser version is 91.0.4472.77 with binary path C:\Program Files\Google\Chrome\Application\chrome.exe\nBuild info: version: '3.141.5', revision: 'd54ebd709a', time: '2018-11-06T11:58:47'\nSystem info: host: 'a000C0W', ip: '10.0.0.5', os.name: 'Windows Server 2016', os.arch: 'amd64', os.version: '10.0', java.version: '11.0.3'\nDriver info: driver.version: unknown\nremote stacktrace: Backtrace:\n\tOrdinal0 [0x0126E7D3+124883]\n\tOrdinal0 [0x0126E7B1+124849]\n\tGetHandleVerifier [0x014B8688+193832]\n\tGetHandleVerifier [0x014D3AC5+305509]\n\tGetHandleVerifier [0x014D021B+291003]\n\tGetHandleVerifier [0x014CE0AC+282444]\n\tGetHandleVerifier [0x014F4A90+440624]\n\tGetHandleVerifier [0x014F47FC+439964]\n\tGetHandleVerifier [0x014F154B+426987]\n\tGetHandleVerifier [0x014D4FFD+310941]\n\tGetHandleVerifier [0x014D5D8E+314414]\n\tGetHandleVerifier [0x014D5D19+314297]\n\tGetHandleVerifier [0x015931EC+1089676]\n\tGetHandleVerifier [0x015917C9+1082985]\n\tGetHandleVerifier [0x015913A3+1081923]\n\tGetHandleVerifier [0x0168D9FD+2115741]\n\tOrdinal0 [0x013BB82E+1488942]\n\tOrdinal0 [0x01355A7D+1071741]\n\tOrdinal0 [0x0135559B+1070491]\n\tOrdinal0 [0x013554B1+1070257]\n\tOrdinal0 [0x0138FF53+1310547]\n\tBaseThreadInitThunk [0x748C0419+25]\n\tRtlGetAppContainerNamedObjectPath [0x772572ED+237]\n\tRtlGetAppContainerNamedObjectPath [0x772572BD+189]\n (SessionNotCreated)

@dougbu
Copy link
Copy Markdown
Contributor

dougbu commented May 27, 2021

@HaoK I tried the backport bot w/ @BrennanConroy's #33019 and #33043 PRs. Both need manual work…

dougbu pushed a commit that referenced this pull request May 28, 2021
@HaoK @dougbu
[release/5.0] Update cert that became valid and broke tests
ea3a504 
- backport of 2e20bab (#32812)
- dupe of #33033

* Update cert to not be valid for 50 years

* Make cert valid in 10 years

* Delete unused copy of certs, update right one

* Skip test for now
@dougbu dougbu mentioned this pull request May 28, 2021
Merged
@dougbu
Copy link
Copy Markdown
Contributor

dougbu commented May 29, 2021

These fixes must go in as part of the first merge for 5.0.8. We should either include 5.0.8 branding in this PR or copy the commits into the 5.0.8 branding PR.

@dougbu dougbu mentioned this pull request May 29, 2021
Closed
dougbu pushed a commit that referenced this pull request Jun 1, 2021
@HaoK @dougbu
[release/5.0] Update cert that became valid and broke tests
6638953 
- backport of 2e20bab (#32812)
- dupe of #33033

* Update cert to not be valid for 50 years

* Make cert valid in 10 years

* Delete unused copy of certs, update right one

* Skip test for now
@dougbu dougbu mentioned this pull request Jun 1, 2021
Merged
@wtgodbe
Copy link
Copy Markdown
Member

wtgodbe commented Jun 1, 2021

Closing in favor of #33198

@wtgodbe wtgodbe closed this Jun 1, 2021
@wtgodbe wtgodbe deleted the backport/pr-32812-to-release/5.0 branch June 1, 2021 21:23
dougbu added a commit that referenced this pull request Jun 1, 2021
@dougbu
[release/5.0] Rebrand for v5.0.8 and get builds working (#33198)
e8bafa3 
* [release/5.9] Update branding to v5.0.8
  - disable baseline validation
* [release/5.0] Update cert that became valid and broke tests
  - backport of 2e20bab (#32812)
  - dupe of #33033
    * Update cert to not be valid for 50 years
    * Make cert valid in 10 years
    * Delete unused copy of certs, update right one
    * Skip test for now
* [release/5.0] Update Chrome driver
  - backport of e7b5aa6 (#33019)
* [release/5.0] Update selenium chrome driver
  - backport of af96aba (#33043)
@dougbu dougbu removed this from the 5.0.8 milestone Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tratcher Tratcher Awaiting requested review from Tratcher Tratcher is a code owner

1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HaoK @dougbu @wtgodbe @Pilchie @BrennanConroy