Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Introduce rootfs for cross-compilation#747

Merged
gkhanna79 merged 2 commits into
dotnet:masterfrom
hqueue:arm/rootfs
Dec 13, 2016
Merged

Introduce rootfs for cross-compilation#747
gkhanna79 merged 2 commits into
dotnet:masterfrom
hqueue:arm/rootfs

Conversation

@hqueue
Copy link
Copy Markdown
Member

@hqueue hqueue commented Dec 9, 2016

skip ci please

Introduce rootfs for cross compilation. I've added scripts for ARM and ARM softfp.
Tested it with sudo ./cross/build-rootfs.sh arm and sudo ./cross/build-rootfs.sh arm-softfp as documented in https://github.com/dotnet/coreclr/blob/master/Documentation/building/cross-building.md to keep consistency with CoreCLR and CoreFX.

Basically the code has been imported from CoreCLR and remove x86 and arm64.
rootfs is exactly same with CoreCLR, i.e. we can also build CoreCLR with this rootfs too.
Later we can refine rootfs to reduce size only with required packages if necessary.
BTW CoreFX has a different configuration.

A script, i.e. build-rootfs.sh, is introduced to setup rootfs.
The rootfs will be used for cross-building corehost in core-setup.

You can setup ARM rootfs by "./build-rootfs.sh arm".
You can setup ARM softfp rootfs by "./build-rootfs.sh arm-softfp".

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
@dnfclas
Copy link
Copy Markdown

dnfclas commented Dec 9, 2016

Hi @hqueue, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Dec 9, 2016

CC @schellap @ramarag @janvorli @gkhanna79 @kouvel PTAL

Related issue: #729

@gkhanna79
Copy link
Copy Markdown
Member

Basically the code has been imported from CoreCLR and remove x86 and arm64

I was thinking about this. Since there is work going on to bring Linux for x86 (https://github.com/dotnet/coreclr/issues/8188), you may just want to keep the x86 support as well (but do not need to test it).

Aside from this, LGTM.

rootfs for x86 is added as suggested.

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Dec 12, 2016

CC @gkhanna79 @schellap @ramarag @janvorli I've added x86 rootfs as suggested.

@gkhanna79
Copy link
Copy Markdown
Member

LGTM - assuming you have validated it, right?

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Dec 13, 2016

@gkhanna79 Yes. For ARM, we built corehost for ARM after appling this PR #747 and PR #749 together and rootfs for x86 is built with this PR #747.

@gkhanna79 gkhanna79 merged commit 2e614e3 into dotnet:master Dec 13, 2016
@hqueue hqueue deleted the arm/rootfs branch January 4, 2017 07:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants