This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Enable cross-compilation of corehost for ARM#749
Merged
Conversation
|
Hi @hqueue, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
hqueue
force-pushed
the
arm/cross-rootfs
branch
from
ad12f1f to
d99226b
Compare
Member
Author
|
CC @schellap @ramarag @janvorli @gkhanna79 @kouvel PTAL You can build corehost for ARM using following command with two PRs for example. Related issue: #729 |
hqueue
force-pushed
the
arm/cross-rootfs
branch
from
d99226b to
2740c8f
Compare
Add a toolchain.cmake for ARM Add a new option "--cross" to enable cross-compilation using rootfs. Use ROOTFS_DIR environmental variable to specify location of rootfs as CoreCLR does. Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Use variable to select rootfs for cross build. Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
|
LGTM! |
hqueue
changed the title
Member
Author
42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be merged after previous PR #747 .
Related issue: #723
Add a toolchain.cmake for ARM
Add a new option "--cross" to enable cross-compilation using rootfs.
Use ROOTFS_DIR environmental variable to specify location of rootfs as CoreCLR does.
I posted this PR to share with other developers.
@jyoungyun @idkiller