This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add CROSS and ROOTFS_DIR environment for ARM#766
Merged
Conversation
The CROSS env is passed through the BuildContext to the build.sh in corehost.
If the value is set, corehost build script gives '--cross' argument.
ROOTFS_DIR can support to specify the location of rootfs as CoreCLR does.
If ROOTFS_DIR env is not defined,
the default value(./cross/rootfs/${TARGETPLATFORM}/) will be used.
Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com>
|
Hi @jyoungyun, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
jyoungyun
changed the title
Member
|
LGTM |
Member
|
@jyoungyun I have merged the other PRs - is this good to merge? |
Author
|
@gkhanna79 Yes, Please merge this patch. Thank you. |
42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be merged after previous PR #747 & #749
The CROSS env is passed through the BuildContext to the build.sh in corehost.
If the value is set, corehost build script gives '--cross' arguments.
ROOTFS_DIR can support to specify the location of rootfs as CoreCLR does.
If ROOTFS_DIR env is not defined,
the default value(./cross/rootfs/${TARGETPLATFORM}/) will be used.
You can build corehost for ARM using following commands.
./build.sh --env-vars TARGETPLATFORM=arm,TARGETRID=ubuntu.16.04-arm,CROSS=1./build.sh --env-vars TARGETPLATFORM=arm,TARGETRID=ubuntu.16.04-arm,CROSS=1,ROOTFS_DIR=/home/jyoung/git/dotnet/rootfs-coreclr/arm/Related issue: #729
I posted this PR to share with other developers.
@hqueue