Move GetLclOffs method to GenTreeLclVarCommon.
#39623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandreenko
added
the
area-CodeGen-coreclr
sandreenko
changed the title
GetLclOffs offset method to GenTreeLclVarCommon.GetLclOffs method to GenTreeLclVarCommon.
sandreenko
force-pushed
the
moveGetLclOffsetToCommon
branch
from
54ca1e5 to
5e47c5a
Compare
added 2 commits
July 21, 2020 01:40
sandreenko
force-pushed
the
moveGetLclOffsetToCommon
branch
from
5e47c5a to
503a792
Compare
Contributor
Author
|
PTAL @AndyAyersMS @CarolEidt @dotnet/jit-contrib This is a refactoring PR for #39424 (review) |
AndyAyersMS
approved these changes
Jul 22, 2020
Member
AndyAyersMS
left a comment
AndyAyersMS
left a comment
There was a problem hiding this comment.
Looks good, just some commenting nits.
| return genRegNumFromMask(tempRegMask); | ||
| } | ||
|
|
||
| uint16_t GenTreeLclVarCommon::GetLclOffs() const |
|
|
||
| // Need an addtional integer register to extract upper 4 bytes from data. | ||
| regNumber tmpReg = treeNode->GetSingleTempReg(); | ||
| regNumber tmpReg = lclVar->GetSingleTempReg(); |
Member
There was a problem hiding this comment.
Can you fix the typo in the line above? addtional -> additional
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
* Move `GetLclOffs` to `Common`. * Start using it. * Review response.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
GetLclOffsoffset method toGenTreeLclVarCommonto simplify blocks that are asking working both with Fields and Vars.If I understood correctly it is what was proposed in #39424 (review)