Subject: preliminary PR to Porting Envoy to C++17#11807
Subject: preliminary PR to Porting Envoy to C++17#11807aimless404 wants to merge 13 commits intoenvoyproxy:masterfrom
Conversation
aimless404
requested review from
jmarantz,
mattklein123,
snowp and
zuercher
as code owners
There was a problem hiding this comment.
Interesting... Why are the braced needed?
There was a problem hiding this comment.
This is actually something related to the slight behavioral difference between absl::optional and std::optional. In C++17, absl::optional forwards to std::optional.
However, in absl::optional, it provides a user-defined default constructor while std::optional doesn't do that. The reason why a user-defined default constructor is a must is because there is a const member in the data structure, and the default constructor is deleted automatically if "any non-variant non-static data member of const-qualified type (or array thereof) with no brace-or-equal-initializer does not have a user-provided default constructor."
If you want to read more about this here is the link https://timsong-cpp.github.io/cppwp/n4659/class.ctor#5.4
|
@yanavlasov Do you mind rerunning the presubmit checks for me? I cannot reproduce the same error that this has on Linux-x64 coverage build locally. |
aimless404
requested review from
PiotrSikora,
alyssawilk,
htuch and
lizan
as code owners
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: Yifan Yang <needyyang@google.com>
…11493) Signed-off-by: knight42 <anonymousknight96@gmail.com> Signed-off-by: Yifan Yang <needyyang@google.com>
Add support for per-listener limits on accepted connections. Signed-off-by: Tony Allen <tony@allen.gg> Signed-off-by: Yifan Yang <needyyang@google.com>
Signed-off-by: Tony Allen <tony@allen.gg> Signed-off-by: Yifan Yang <needyyang@google.com>
…eject partial headers that exceed configured limits (envoyproxy#145) Signed-off-by: antonio <avd@google.com> Signed-off-by: Yifan Yang <needyyang@google.com>
This commit adds a new stream flush timeout to guard against a remote server that does not open window once an entire stream has been buffered for flushing. Additional stats have also been added to better understand the codecs view of active streams as well as amount of data buffered. Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Yifan Yang <needyyang@google.com>
…ation due to tracking of H2 data and control frames in the output buffer (envoyproxy#144) Signed-off-by: antonio <avd@google.com> Signed-off-by: Yifan Yang <needyyang@google.com>
) Fixes envoyproxy/envoy-setec#180 Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Yifan Yang <needyyang@google.com>
…11624) Signed-off-by: Erik Bos <erik@xs4all.nl> Signed-off-by: Yifan Yang <needyyang@google.com>
Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Yifan Yang <needyyang@google.com>
The else-clause would trip when the on-header-present block was absent, irrespective of if the header was actually absent. Signed-off-by: Ariane van der Steldt <avandersteldt@slack-corp.com> Signed-off-by: Yifan Yang <needyyang@google.com>
This is the PR that does the setup work needed to fix some incompatiblity issue with the current codebase and C++17 Signed-off-by: Yifan Yang <needyyang@google.com>
Signed-off-by: Yifan Yang <needyyang@google.com>
9 participants
This is the PR that does the setup work needed to fix some
incompatiblity issue with the current codebase and C++17.
This is a part of the draft PR #11570 that intends to
port Envoy to C++17, sans all the changes to build configurations.
Signed-off-by: Yifan Yang needyyang@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]