chore(tracing): update dd-trace-cpp to 0.1.11#29354
Conversation
|
Hi @sebbrandt87, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
@sebbrandt87 there are a large number of changes here that seem unrelated to the PR my guess is that you ran some of the tooling outside of our build container and with incorrect versions |
indeed, let me recheck and recommit, sorry for the inconvenience |
4b4a8b4 to
d09f065
Compare
phlax
left a comment
There was a problem hiding this comment.
lgtm, pending CI, thanks @sebbrandt87
In file included from bazel-out/aarch64-opt/bin/external/com_github_datadog_dd_trace_cpp/_virtual_includes/dd_trace_cpp/datadog/tracer.h:15:
bazel-out/aarch64-opt/bin/external/com_github_datadog_dd_trace_cpp/_virtual_includes/dd_trace_cpp/datadog/expected.h:108:9: error: object of type 'std::variant<Span, Error>' cannot be assigned because its copy assignment operator is implicitly deleted
data_ = std::forward<Other>(other);
^
source/extensions/tracers/datadog/tracer.cc:109:16: note: in instantiation of function template specialization 'datadog::tracing::Expected<datadog::tracing::Span>::operator=<datadog::tracing::Span>' requested here
maybe_span = tracer.create_span(span_config);
^
/opt/llvm/bin/../include/c++/v1/variant:1362:12: note: explicitly defaulted function was implicitly deleted here
variant& operator=(const variant&) = default;
^
/opt/llvm/bin/../include/c++/v1/variant:1262:7: note: copy assignment operator of 'variant<datadog::tracing::Span, datadog::tracing::Error>' is implicitly deleted because base class '__sfinae_assign_base<__all<(is_copy_constructible_v<Span> && is_copy_assignable_v<Span>), (is_copy_constructible_v<Error> && is_copy_assignable_v<Error>)>::value, __all<(is_move_constructible_v<Span> && is_move_assignable_v<Span>), (is_move_constructible_v<Error> && is_move_assignable_v<Error>)>::value>' has a deleted copy assignment operator
private __sfinae_assign_base<
^
/opt/llvm/bin/../include/c++/v1/__tuple:528:25: note: 'operator=' has been explicitly marked deleted here
__sfinae_assign_base& operator=(__sfinae_assign_base const&) = delete;
^ |
|
@sebbrandt87 i think the above fail looks real |
adisuissa
left a comment
There was a problem hiding this comment.
Thanks for doing the cross-repo fixes.
Left a small comment (also need to fix the conflict), but otherwise LGTM.
|
/wait Waiting for main merging and comments to be resolved. |
b8fca50 to
7ad4c16
Compare
|
Please fix CI error |
7ad4c16 to
07120c9
Compare
|
CI error seems relevant, can you PTAL? |
|
I try my best with spare time I will find. Any advice or helping hand in solving much appreciated. 🤝 |
I don't have cycles to address this. The cause for the issue is described in a prior comment. /wait |
Okay. |
|
0.1.11 is available #30552 |
07120c9 to
b489ff2
Compare
- include new propagation style b3multi compatibility see https://github.com/DataDog/dd-trace-cpp/blob/v0.1.11/src/datadog/propagation_style.cpp#L39-L49 Co-authored-by: phlax <phlax@users.noreply.github.com> Signed-off-by: Brandt, Sebastian (ITO-PC) <sebastian.brandt@tchibo.de>
b489ff2 to
b520b0a
Compare
|
Still same error as before, waiting for a solution to the underlying issue. |
dd-trace-cpp is Datadog's core C++ tracing library, and is used by Envoy to provide tracing via Datadog. Envoy is currently consuming an older version of dd-trace-cpp. Subsequent releases of dd-trace-cpp were not compatible with the Datadog tracing extension here. These changes make the Datadog tracing extension compatible with the latest release of dd-trace-cpp, v0.1.12. The changes are mostly in unit tests. Newer versions of dd-trace-cpp send more HTTP requests to the Datadog Agent, and so tests that assumed the number of requests were broken. There are also some changes involving how timeouts are handled by dd-trace-cpp. These changes address #30957, #29354, and #31360. Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
|
@sebbrandt87 i think this has been superseded we are now up-to-date for this dep - so im going to close - thanks for working on it |
dd-trace-cpp is Datadog's core C++ tracing library, and is used by Envoy to provide tracing via Datadog. Envoy is currently consuming an older version of dd-trace-cpp. Subsequent releases of dd-trace-cpp were not compatible with the Datadog tracing extension here. These changes make the Datadog tracing extension compatible with the latest release of dd-trace-cpp, v0.1.12. The changes are mostly in unit tests. Newer versions of dd-trace-cpp send more HTTP requests to the Datadog Agent, and so tests that assumed the number of requests were broken. There are also some changes involving how timeouts are handled by dd-trace-cpp. These changes address envoyproxy#30957, envoyproxy#29354, and envoyproxy#31360. Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
dd-trace-cpp is Datadog's core C++ tracing library, and is used by Envoy to provide tracing via Datadog. Envoy is currently consuming an older version of dd-trace-cpp. Subsequent releases of dd-trace-cpp were not compatible with the Datadog tracing extension here. These changes make the Datadog tracing extension compatible with the latest release of dd-trace-cpp, v0.1.12. The changes are mostly in unit tests. Newer versions of dd-trace-cpp send more HTTP requests to the Datadog Agent, and so tests that assumed the number of requests were broken. There are also some changes involving how timeouts are handled by dd-trace-cpp. These changes address envoyproxy#30957, envoyproxy#29354, and envoyproxy#31360. Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Fix #30552
Commit Message:
chore(tracing): update dd-trace-cpp to 0.1.11
Additional Description:
see https://github.com/DataDog/dd-trace-cpp/blob/v0.1.11/src/datadog/propagation_style.cpp#L39-L49
Signed-off-by: Brandt, Sebastian (ITO-PC) sebastian.brandt@tchibo.de
Risk Level: Low
Testing: through implemented testing already present
Docs Changes: N/A
Release Notes: Yes
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]