[bp/1.28] tracing: dd-trace-cpp v0.1.12 (#31526)#32014
Conversation
dd-trace-cpp is Datadog's core C++ tracing library, and is used by Envoy to provide tracing via Datadog. Envoy is currently consuming an older version of dd-trace-cpp. Subsequent releases of dd-trace-cpp were not compatible with the Datadog tracing extension here. These changes make the Datadog tracing extension compatible with the latest release of dd-trace-cpp, v0.1.12. The changes are mostly in unit tests. Newer versions of dd-trace-cpp send more HTTP requests to the Datadog Agent, and so tests that assumed the number of requests were broken. There are also some changes involving how timeouts are handled by dd-trace-cpp. These changes address envoyproxy#30957, envoyproxy#29354, and envoyproxy#31360. Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
|
Hi @Smeb, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
repokitteh-read-only
Bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
|
None of the issues in the Envoy Datadog extension that I've addressed since v1.27 involved changes to the dd-trace-cpp library. Instead, the bugs were introduced in changes that I made to Envoy. I doubt that backporting a more recent dd-trace-cpp onto Envoy's release branches will fix any bugs, and so I think that it's inappropriate to do so. @Smeb has described the tracing issues that he's encountered since upgrading to an Istio version that uses Envoy versions that contain Datadog tracing bugs. Let's address those issues individually. They likely will not involve changes to dd-trace-cpp, nor backporting dd-trace-cpp releases onto Envoy releases. |
|
Closed based on the above comment. |
3 participants
We use Istio and see issues with the datadog tracer in Envoy 1.27/1.28. We're opening this backport as we believe that the later version of the tracer library should resolve some (hopefully all) the issues we see.
As with the last backports I opened, I ran the unit tests locally (using
libc++).Commit Message: [bp/1.28] Datadog: tracing: dd-trace-cpp v0.1.12
Additional Description:
This is the backport of #31526
Risk Level: low
Testing: local unit tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Fixes: #30957, #29354, and #31360.