deps: Bump com_github_datadog_dd_trace_cpp -> 0.1.12#31360
Closed
dependency-envoy[bot] wants to merge 1 commit into
Closed
deps: Bump com_github_datadog_dd_trace_cpp -> 0.1.12#31360dependency-envoy[bot] wants to merge 1 commit into
com_github_datadog_dd_trace_cpp -> 0.1.12#31360dependency-envoy[bot] wants to merge 1 commit into
Conversation
Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>
repokitteh-read-only
Bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Contributor
|
CI errors look real. Lots of change between current /cc codeowners @cgilmour @dgoffredo @dmehala @mattklein123 |
Contributor
|
Yes, the Datadog unit tests (and some other code) within Envoy require changes to accommodate backward incompatible changes made to dd-trace-cpp. My teammate (@cgilmour) has a branch with the required changes in Datadog's fork of Envoy, but we need to add some more testing with regard to HTTP request timeouts. We'll prioritize finishing those changes, and then propose them upstream here. |
Contributor
|
Closing in favor of #31526 |
RyanTheOptimist
pushed a commit
that referenced
this pull request
Jan 5, 2024
dd-trace-cpp is Datadog's core C++ tracing library, and is used by Envoy to provide tracing via Datadog. Envoy is currently consuming an older version of dd-trace-cpp. Subsequent releases of dd-trace-cpp were not compatible with the Datadog tracing extension here. These changes make the Datadog tracing extension compatible with the latest release of dd-trace-cpp, v0.1.12. The changes are mostly in unit tests. Newer versions of dd-trace-cpp send more HTTP requests to the Datadog Agent, and so tests that assumed the number of requests were broken. There are also some changes involving how timeouts are handled by dd-trace-cpp. These changes address #30957, #29354, and #31360. Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Smeb
pushed a commit
to Smeb/envoy
that referenced
this pull request
Jan 24, 2024
dd-trace-cpp is Datadog's core C++ tracing library, and is used by Envoy to provide tracing via Datadog. Envoy is currently consuming an older version of dd-trace-cpp. Subsequent releases of dd-trace-cpp were not compatible with the Datadog tracing extension here. These changes make the Datadog tracing extension compatible with the latest release of dd-trace-cpp, v0.1.12. The changes are mostly in unit tests. Newer versions of dd-trace-cpp send more HTTP requests to the Datadog Agent, and so tests that assumed the number of requests were broken. There are also some changes involving how timeouts are handled by dd-trace-cpp. These changes address envoyproxy#30957, envoyproxy#29354, and envoyproxy#31360. Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
Smeb
pushed a commit
to Smeb/envoy
that referenced
this pull request
Jan 24, 2024
dd-trace-cpp is Datadog's core C++ tracing library, and is used by Envoy to provide tracing via Datadog. Envoy is currently consuming an older version of dd-trace-cpp. Subsequent releases of dd-trace-cpp were not compatible with the Datadog tracing extension here. These changes make the Datadog tracing extension compatible with the latest release of dd-trace-cpp, v0.1.12. The changes are mostly in unit tests. Newer versions of dd-trace-cpp send more HTTP requests to the Datadog Agent, and so tests that assumed the number of requests were broken. There are also some changes involving how timeouts are handled by dd-trace-cpp. These changes address envoyproxy#30957, envoyproxy#29354, and envoyproxy#31360. Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
This was referenced Jan 24, 2024
phlax
deleted the
dependency/bazel/com_github_datadog_dd_trace_cpp/0.1.12
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by Envoy dependency bot for @phlax
Fix #30957
Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>