Skip to content

deps: Bump rules_rust to 0.67.0#42194

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
mmorel-35:rules_rust@0.67.0
Nov 23, 2025
Merged

deps: Bump rules_rust to 0.67.0#42194
phlax merged 1 commit intoenvoyproxy:mainfrom
mmorel-35:rules_rust@0.67.0

Conversation

@mmorel-35
Copy link
Copy Markdown
Contributor

@mmorel-35 mmorel-35 commented Nov 22, 2025 •
edited
Loading

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
Fixes #41678
[Optional Fixes commit #PR or SHA]
Fixes #41630 Fixes #41172
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only Bot commented Nov 22, 2025

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #42194 was opened by mmorel-35.

see: more, trace.

@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Nov 22, 2025
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only Bot commented Nov 22, 2025

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @agrawroh

🐱

Caused by: #42194 was opened by mmorel-35.

see: more, trace.

@phlax
Copy link
Copy Markdown
Member

phlax commented Nov 22, 2025

im almost certain this wont work without enabling cc_toolchain_resolution

phlax
phlax reviewed Nov 22, 2025
View reviewed changes
Comment thread .bazelrc Outdated
phlax
phlax reviewed Nov 22, 2025
View reviewed changes
Comment thread .bazelrc Outdated
@mmorel-35 mmorel-35 force-pushed the rules_rust@0.67.0 branch 2 times, most recently from 4b4599d to cb828d1 Compare November 22, 2025 21:42
@mmorel-35 mmorel-35 marked this pull request as ready for review November 22, 2025 22:02
@mmorel-35
Copy link
Copy Markdown
Contributor Author

mmorel-35 commented Nov 22, 2025

/retest

phlax
phlax reviewed Nov 23, 2025
View reviewed changes
Comment thread .bazelrc
Comment thread test/extensions/dynamic_modules/test_data/rust/http_integration_test.rs
@mmorel-35 mmorel-35 force-pushed the rules_rust@0.67.0 branch 2 times, most recently from c875e9f to be3732a Compare November 23, 2025 07:03
@mmorel-35
Copy link
Copy Markdown
Contributor Author

mmorel-35 commented Nov 23, 2025

/retest

@mmorel-35 mmorel-35 force-pushed the rules_rust@0.67.0 branch 2 times, most recently from ec58d4b to 5ec4ceb Compare November 23, 2025 09:07
@mmorel-35
Copy link
Copy Markdown
Contributor Author

mmorel-35 commented Nov 23, 2025

/retest

@phlax
Copy link
Copy Markdown
Member

phlax commented Nov 23, 2025

@mmorel-35 looks like you have cc_toolchain_resolution working - nice work!

im wondering if its possible to separate out that change from the rules_rust update - its the more significant change and has implications for downstream builders so would be better to land separately (or at least i think we need to change the commit title)

@mmorel-35
Copy link
Copy Markdown
Contributor Author

mmorel-35 commented Nov 23, 2025

im wondering if its possible to separate out that change from the rules_rust update - its the more significant change and has implications for downstream builders so would be better to land separately (or at least i think we need to change the commit title)

I created #42201

@mmorel-35 mmorel-35 force-pushed the rules_rust@0.67.0 branch 2 times, most recently from d957572 to f879520 Compare November 23, 2025 10:05
@mmorel-35 mmorel-35 mentioned this pull request Nov 23, 2025
Closed
@mmorel-35
Copy link
Copy Markdown
Contributor Author

mmorel-35 commented Nov 23, 2025

Needs #42194 and #42198

phlax
phlax reviewed Nov 23, 2025
View reviewed changes
Comment thread bazel/repositories.bzl
@mmorel-35
deps: Bump rules_rust to 0.67.0
ffdbca0 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
phlax
phlax approved these changes Nov 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mmorel-35

@repokitteh-read-only repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Nov 23, 2025
@phlax phlax enabled auto-merge (squash) November 23, 2025 10:44
@phlax phlax merged commit ef11621 into envoyproxy:main Nov 23, 2025
25 checks passed
@mmorel-35 mmorel-35 deleted the rules_rust@0.67.0 branch November 23, 2025 10:55
grnmeira pushed a commit to grnmeira/envoy that referenced this pull request Mar 20, 2026
@mmorel-35 @grnmeira
deps: Bump rules_rust to 0.67.0 (envoyproxy#42194)
580b49c 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Gustavo <grnmeira@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phlax phlax phlax approved these changes

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 is a code owner

@mathetake mathetake Awaiting requested review from mathetake mathetake is a code owner

Assignees

@agrawroh agrawroh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Newer release available rules_rust: 0.67.0 (current: 0.56.0)

3 participants

@mmorel-35 @phlax @agrawroh