[bp/1.37] Flakes stack#44644
Merged
phlax merged 8 commits intoenvoyproxy:release/v1.37from Apr 27, 2026
Merged
Conversation
Member
Author
|
theres probably a couple more flake fixes we could backport - but these ones have all been around as long as this branch and appear to fix, so lets land these for now |
jwendell
previously approved these changes
Apr 24, 2026
jwendell
previously approved these changes
Apr 24, 2026
phlax
force-pushed
the
bp-1.37-flakes
branch
3 times, most recently
from
394449f to
ed7e1c1
Compare
phlax
requested review from
agrawroh,
mattklein123 and
yanjunxiang-google
as code owners
repokitteh-read-only
Bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
as this can still flake in msan Signed-off-by: Ryan Northey <ryan@synca.io>
Scale RequestTimeoutMs by TIMEOUT_FACTOR to match IdleTimeoutMs. The hard-coded 200ms races test setup on loaded/sanitizer runs, causing the request timer to fire before the test body executes. fix envoyproxy#26979 Signed-off-by: Ryan Northey <ryan@synca.io>
envoyproxy#44500) QuicSpdyClientSession::ShouldCreateOutgoingBidirectionalStream() can legitimately return false, but we return true unconditionally to avoid a nullptr deref in QuicHttpClientConnectionImpl::newStream. The existing ASSERT on the parent's return value was therefore incorrect and triggered flakes (e.g. in buffer_accounting_integration_test on MSAN). Drop the ASSERT and update the comment. Fixes envoyproxy#41526 --------- Signed-off-by: Ryan Northey <ryan@synca.io>
by separating the tests Hopefully fix: envoyproxy#44427 Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
…xy#43711) Signed-off-by: Ryan Northey <ryan@synca.io>
ravenblackx
approved these changes
Apr 27, 2026
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.