fix: propagate the HTTPFilter translation errors to the outer layer by zhaohuabing · Pull Request #7556 · envoyproxy/gateway

zhaohuabing · 2025-11-19T06:13:48Z

This PR propagates the HTTPFilter translation errors to the out layer, so they can be handled with other route translation errors together in the processHTTPRouteParentRefs method.

This PR doesn't fix #7545, but it will allow us to associate an HTTPFilter translation error with a specific HTTPRule. This is a prerequisite for resolving #7545, where we need to set the Accepted status as true for mixed valid and invalid rules and generate the xDS for valid rules.

codecov · 2025-11-19T06:22:58Z

Codecov Report

❌ Patch coverage is 75.00000% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.26%. Comparing base (1d1093c) to head (be51f25).
⚠️ Report is 524 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/gatewayapi/filters.go	76.41%	47 Missing and 3 partials ⚠️
internal/gatewayapi/route.go	50.00%	7 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7556      +/-   ##
==========================================
- Coverage   72.33%   72.26%   -0.08%     
==========================================
  Files         232      232              
  Lines       34114    34103      -11     
==========================================
- Hits        24676    24644      -32     
- Misses       7668     7682      +14     
- Partials     1770     1777       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

zhaohuabing · 2025-11-19T07:45:47Z

I just found another issue while working on this PR: currently, the ir routes are not generated for HTTPRoute Rules with invalid HTTPFilters. If any rules have invalid filters, the user requests will get 404 not found.

We should generate a 500 directResponse for these rules, like what we did with failed backendRefs. Let's handle this in a separate PR.

zhaohuabing · 2025-11-20T04:16:11Z

-        status: "False"
+        message: Route is accepted
+        reason: Accepted
+        status: "True"


Accepted should be True for unresolved filters.

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

kkk777-7 · 2025-11-24T08:00:31Z

LGTM, thanks!

arkodg · 2025-11-25T19:38:09Z

        type: Accepted
      - lastTransitionTime: null
-        message: 'Unable to translate HTTPRouteFilter: default/direct-response-value-ref-not-found'
+        message: 'Unable to translate HTTPRouteFilter: default/direct-response-value-ref-not-found.'


not related to this PR, but we should consider updating reason from BackendNotFound to something better for this case in the future

arkodg

LGTM thanks

…nvoyproxy#7556) * progate the HTTPFilter validation errors to the outer layer Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>

* fix: avoid metric increments on no-op delete reconcile paths (#8480) * fix: avoid metric increments on no-op delete reconcile paths Signed-off-by: Felipe Sabadini Facina <fsabadini@hotmail.com> * Update internal/infrastructure/kubernetes/infra_resource_test.go Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com> * Update internal/infrastructure/kubernetes/infra_resource_test.go Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com> --------- Signed-off-by: Felipe Sabadini Facina <fsabadini@hotmail.com> Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com> Co-authored-by: Isaac Wilson <isaac.wilson514@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> * fix: restore failure-path metric recording for delete and HPA reconcile (#8656) Fixes #8651 Signed-off-by: Felipe Sabadini Facina <fsabadini@hotmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> * fix: helm secrets rbac for gateway namespace with watch list of namespaces (#8706) * fix: helm secrets rbac for gateway namespace with watch list of namespaces Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> * add release notes Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> * review update Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> --------- Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> Co-authored-by: Rudrakh Panigrahi <rudrakh97@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> * fix: handle network errors in rate limit e2e tests (#8446) Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> * fix: propagate the HTTPFilter translation errors to the outer layer (#7556) * progate the HTTPFilter validation errors to the outer layer Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> * fix: return 500 error for invalid filters (#7605) return 500 error for invalid filters Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> * fix: prevent configuring requestMirror filter and directResponse/RequestRedirect filter together (#7474) * fix: prevent configuring RequestMirror and DirectResponse filters together Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> check redirect respose filter Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * address comments Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix lint Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> * fix bug with grpcroute mirror filter (#8541) * fix bug with grpcroute mirror filter Signed-off-by: Adam Buran <aburan@roblox.com> * add indexers test Signed-off-by: Adam Buran <aburan@roblox.com> * add release note Signed-off-by: Adam Buran <aburan@roblox.com> --------- Signed-off-by: Adam Buran <aburan@roblox.com> Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> * fix: normalize CRLF line endings in htpasswd basic auth secrets (#8557) Fixes #8554 Signed-off-by: stekole <stefan@sandnetworks.com> Signed-off-by: stekole <30674956+stekole@users.noreply.github.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> * fix: status for mirror backend (#8675) Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> * fix: set HTTPRoute Accepted condition as true with mixed invalid and valid rules (#7625) * set HTTPRoute Accepted condition as true with mixed invalid and valid rules Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> * fix: basic auth validation (#8053) * fix basic auth validation Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> * [release/v1.6] fix gen check Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> --------- Signed-off-by: Felipe Sabadini Facina <fsabadini@hotmail.com> Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com> Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> Signed-off-by: Adam Buran <aburan@roblox.com> Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: stekole <stefan@sandnetworks.com> Signed-off-by: stekole <30674956+stekole@users.noreply.github.com> Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Co-authored-by: Felipe Sabadini <fsabadini@hotmail.com> Co-authored-by: Isaac Wilson <isaac.wilson514@gmail.com> Co-authored-by: Karol Szwaj <karol.szwaj@gmail.com> Co-authored-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Co-authored-by: aburanrbx <aburan@roblox.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Co-authored-by: stekole <30674956+stekole@users.noreply.github.com> Co-authored-by: Kota Kimura <86363983+kkk777-7@users.noreply.github.com>

zhaohuabing requested a review from a team as a code owner November 19, 2025 06:13

zhaohuabing marked this pull request as draft November 19, 2025 06:14

zhaohuabing force-pushed the filter-status-error branch from dc7f5b0 to 0dcab0a Compare November 19, 2025 07:05

zhaohuabing commented Nov 19, 2025

View reviewed changes

Comment thread internal/gatewayapi/testdata/extensions/httproute-with-custom-backend-invalid-group.out.yaml Outdated

zhaohuabing marked this pull request as ready for review November 19, 2025 07:34

zhaohuabing requested a review from arkodg November 19, 2025 07:39

zhaohuabing changed the title ~~Propagate the HTTPFilter translation errors to the outer layer~~ fix: propagate the HTTPFilter translation errors to the outer layer Nov 19, 2025

zhaohuabing force-pushed the filter-status-error branch from 0dcab0a to ca5e6f3 Compare November 19, 2025 08:52

zirain force-pushed the filter-status-error branch from ca5e6f3 to 008b334 Compare November 20, 2025 00:07

arkodg reviewed Nov 20, 2025

View reviewed changes

Comment thread internal/gatewayapi/filters.go

arkodg added this to the v1.7.0-rc.1 Release milestone Nov 20, 2025

zhaohuabing requested a review from arkodg November 20, 2025 04:11

zhaohuabing force-pushed the filter-status-error branch from 33b4b12 to 8001531 Compare November 20, 2025 04:14

zhaohuabing commented Nov 20, 2025

View reviewed changes

lboynton reviewed Nov 20, 2025

View reviewed changes

Comment thread internal/gatewayapi/testdata/httproute-with-header-filter-no-valid-headers.out.yaml Outdated

zhaohuabing requested a review from lboynton November 24, 2025 00:52

zhaohuabing added 5 commits November 24, 2025 08:52

progate the HTTPFilter validation errors to the outer layer

2d1d1c9

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

address comments

14a1543

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

address comments

434a09a

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

continue processing the remain filters when validation fials

a044a92

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

fix typo

c29c132

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

zhaohuabing force-pushed the filter-status-error branch from de9a6cc to c29c132 Compare November 24, 2025 00:52

kkk777-7 reviewed Nov 24, 2025

View reviewed changes

Comment thread internal/gatewayapi/filters.go

Comment thread internal/gatewayapi/filters.go Outdated

address comments

be51f25

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>

zhaohuabing requested a review from kkk777-7 November 24, 2025 07:54

kkk777-7 approved these changes Nov 24, 2025

View reviewed changes

arkodg reviewed Nov 25, 2025

View reviewed changes

arkodg approved these changes Nov 26, 2025

View reviewed changes

zhaohuabing merged commit 0623ca5 into envoyproxy:main Nov 26, 2025
52 of 55 checks passed

zhaohuabing deleted the filter-status-error branch November 26, 2025 02:36

zhaohuabing mentioned this pull request Nov 28, 2025

fix: set HTTPRoute Accepted condition as true with mixed invalid and valid rules #7625

Merged

rudrakhp added the cherrypick/release-v1.6.6 label Apr 15, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: propagate the HTTPFilter translation errors to the outer layer#7556

fix: propagate the HTTPFilter translation errors to the outer layer#7556
zhaohuabing merged 6 commits intoenvoyproxy:mainfrom
zhaohuabing:filter-status-error

zhaohuabing commented Nov 19, 2025 •

edited

Loading

Uh oh!

codecov Bot commented Nov 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

zhaohuabing commented Nov 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

zhaohuabing Nov 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kkk777-7 commented Nov 24, 2025

Uh oh!

arkodg Nov 25, 2025

Uh oh!

arkodg left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

zhaohuabing commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

zhaohuabing commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

zhaohuabing Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kkk777-7 commented Nov 24, 2025

Uh oh!

arkodg Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

arkodg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zhaohuabing commented Nov 19, 2025 •

edited

Loading

codecov Bot commented Nov 19, 2025 •

edited

Loading

zhaohuabing commented Nov 19, 2025 •

edited

Loading