fix: set HTTPRoute Accepted condition as true with mixed invalid and valid rules

[zhaohuabing]

This PR is the follow-up of #7556.

Currently, the Gateway API translator sets HTTPRoute Accepted condition as false when any of the its rules is invalid. This PR changes the behavior to set Accepted as false only if all rules are invalid, if both valid and invalid rules exist, the Accepted is set to true, and a PartiallyInvalid condition is added to the status.

The updated behavior aligns with the Gateway API spec.

https://gateway-api.sigs.k8s.io/geps/gep-1364/

A HTTPRoute with two rules, one valid and one which specifies a HTTPRequestRedirect filter _and a HTTPURLRewrite filter. Accepted is true, because the valid rule can produce some config in the data plane. We'll need to raise the more specific error condition for an incompatible filter combination as well to make the partial validity clear.

RouteConditionPartiallyInvalid:

// This condition indicates that the Route contains a combination of both
// valid and invalid rules.
//
// When this happens, implementations MUST take one of the following
// approaches:
//
// 1) Drop Rule(s): With this approach, implementations will drop the
// invalid Route Rule(s) until they are fully valid again. The message
// for this condition MUST start with the prefix "Dropped Rule" and
// include information about which Rules have been dropped. In this
// state, the "Accepted" condition MUST be set to "True" with the latest
// generation of the resource.
// 2) Fall Back: With this approach, implementations will fall back to the
// last known good state of the entire Route. The message for this
// condition MUST start with the prefix "Fall Back" and include
// information about why the current Rule(s) are invalid. To represent
// this, the "Accepted" condition MUST be set to "True" with the
// generation of the last known good state of the resource.

Fix: #7545

[codecov]

Codecov Report

❌ Patch coverage is 87.77778% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.37%. Comparing base (7864465) to head (6cf22c4).
⚠️ Report is 505 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/gatewayapi/route.go	87.77%	9 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7625      +/-   ##
==========================================
+ Coverage   72.33%   72.37%   +0.03%     
==========================================
  Files         232      232              
  Lines       34143    34209      +66     
==========================================
+ Hits        24699    24760      +61     
- Misses       7669     7675       +6     
+ Partials     1775     1774       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[arkodg]

thoughts on skipped vs dropped

[zhaohuabing]

This is required in the Gateway API spec:

1. Drop Rule(s): With this approach, implementations will drop the
   invalid Route Rule(s) until they are fully valid again. The message
   for this condition MUST start with the prefix "Dropped Rule" and
   include information about which Rules have been dropped. In this
   state, the "Accepted" condition MUST be set to "True" with the latest
   generation of the resource.

[arkodg]

ah thanks !

[arkodg]

LGTM thanks

[kkk777-7]

LGTM, thanks!
This is a good change that aligns with the Gateway API Spec :)

[kkk777-7]

/retest