[release/v1.6] cherry-pick for v1.6.6#8761
Merged
rudrakhp merged 13 commits intoenvoyproxy:release/v1.6from Apr 16, 2026
Merged
[release/v1.6] cherry-pick for v1.6.6#8761rudrakhp merged 13 commits intoenvoyproxy:release/v1.6from
rudrakhp merged 13 commits intoenvoyproxy:release/v1.6from
Conversation
…oxy#8480) * fix: avoid metric increments on no-op delete reconcile paths Signed-off-by: Felipe Sabadini Facina <fsabadini@hotmail.com> * Update internal/infrastructure/kubernetes/infra_resource_test.go Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com> * Update internal/infrastructure/kubernetes/infra_resource_test.go Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com> --------- Signed-off-by: Felipe Sabadini Facina <fsabadini@hotmail.com> Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com> Co-authored-by: Isaac Wilson <isaac.wilson514@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
…le (envoyproxy#8656) Fixes envoyproxy#8651 Signed-off-by: Felipe Sabadini Facina <fsabadini@hotmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
…paces (envoyproxy#8706) * fix: helm secrets rbac for gateway namespace with watch list of namespaces Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> * add release notes Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> * review update Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> --------- Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> Co-authored-by: Rudrakh Panigrahi <rudrakh97@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
…nvoyproxy#7556) * progate the HTTPFilter validation errors to the outer layer Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
return 500 error for invalid filters Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
…estRedirect filter together (envoyproxy#7474) * fix: prevent configuring RequestMirror and DirectResponse filters together Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> check redirect respose filter Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * address comments Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * fix lint Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> --------- Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
* fix bug with grpcroute mirror filter Signed-off-by: Adam Buran <aburan@roblox.com> * add indexers test Signed-off-by: Adam Buran <aburan@roblox.com> * add release note Signed-off-by: Adam Buran <aburan@roblox.com> --------- Signed-off-by: Adam Buran <aburan@roblox.com> Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
…yproxy#8557) Fixes envoyproxy#8554 Signed-off-by: stekole <stefan@sandnetworks.com> Signed-off-by: stekole <30674956+stekole@users.noreply.github.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
…valid rules (envoyproxy#7625) * set HTTPRoute Accepted condition as true with mixed invalid and valid rules Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
* fix basic auth validation Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74ab97f054
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Comment on lines
+970
to
+972
| if irRoute.DirectResponse != nil || irRoute.Redirect != nil { | ||
| continue | ||
| } |
There was a problem hiding this comment.
When processFilterError != nil, this loop skips routes that already have DirectResponse/Redirect set, so an invalid GRPCRoute rule can continue serving its configured response instead of the intended 500 fail-closed response. This is reachable when one filter in a rule is invalid (for example, malformed header modifier) and another filter sets a direct response via ExtensionRef; in mixed valid/invalid routes, the invalid rule is still attached but not converted to 500.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/v1.6 #8761 +/- ##
================================================
+ Coverage 72.99% 73.18% +0.19%
================================================
Files 231 231
Lines 34540 34699 +159
================================================
+ Hits 25211 25394 +183
+ Misses 7480 7467 -13
+ Partials 1849 1838 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cnvergence
previously approved these changes
Apr 15, 2026
zirain
previously approved these changes
Apr 15, 2026
zhaohuabing
previously approved these changes
Apr 15, 2026
zirain
previously approved these changes
Apr 15, 2026
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
zirain
approved these changes
Apr 16, 2026
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick set: https://github.com/envoyproxy/gateway/pulls?q=+is%3Apr+label%3Acherrypick%2Frelease-v1.6.6+