Skip to content

Add support for the GRPCRoute API#907

Closed
HoangTheQuyen wants to merge 23 commits intoenvoyproxy:mainfrom
HoangTheQuyen:main
Closed

Add support for the GRPCRoute API#907
HoangTheQuyen wants to merge 23 commits intoenvoyproxy:mainfrom
HoangTheQuyen:main

Conversation

@HoangTheQuyen
Copy link
Copy Markdown

@HoangTheQuyen HoangTheQuyen commented Jan 14, 2023 •
edited
Loading

@HoangTheQuyen HoangTheQuyen requested a review from a team as a code owner January 14, 2023 04:32
@zirain
Copy link
Copy Markdown
Member

zirain commented Jan 15, 2023

please rebase from main branch then fix DCO

@HoangTheQuyen
Copy link
Copy Markdown
Author

HoangTheQuyen commented Jan 16, 2023

please rebase from main branch then fix DCO

I repaired it. Did you check if it is correct?

@HoangTheQuyen HoangTheQuyen marked this pull request as draft January 16, 2023 08:33
@HoangTheQuyen HoangTheQuyen marked this pull request as ready for review January 16, 2023 08:33
@zirain zirain mentioned this pull request Jan 16, 2023
Closed
@HoangTheQuyen
Copy link
Copy Markdown
Author

HoangTheQuyen commented Jan 16, 2023

Can anyone help me review it?

@HoangTheQuyen HoangTheQuyen reopened this Jan 16, 2023
@HoangTheQuyen HoangTheQuyen reopened this Jan 16, 2023
@HoangTheQuyen
Copy link
Copy Markdown
Author

HoangTheQuyen commented Jan 17, 2023 •
edited
Loading

Please guide me on how to fix it ? @zirain @Xunzhuo @arkodg @danehans

zirain and others added 18 commits January 17, 2023 17:18
@HoangTheQuyen
lint: improve golanglint (#911)
34a82f9 
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>

Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Signed-off-by: geotech <geotech@geotechs-MacBook-Pro-3.local>
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
@HoangTheQuyen
Update contexts.go
1ea6fb7 
Signed-off-by: HoangTheQuyen <38252060+HoangTheQuyen@users.noreply.github.com>
Signed-off-by: geotech <geotech@geotechs-MacBook-Pro-3.local>
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
@HoangTheQuyen
Config listener for multiple routes
95ac5e3 
Signed-off-by: HoangTheQuyen <38252060+HoangTheQuyen@users.noreply.github.com>
Signed-off-by: geotech <geotech@geotechs-MacBook-Pro-3.local>
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
@HoangTheQuyen
resolve conflic
81af544 
Signed-off-by: geotech <geotech@geotechs-MacBook-Pro-3.local>
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
@HoangTheQuyen
Update GRPC translater
8e688e6 
Signed-off-by: HoangTheQuyen <38252060+HoangTheQuyen@users.noreply.github.com>
Signed-off-by: geotech <geotech@geotechs-MacBook-Pro-3.local>
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
@HoangTheQuyen
Update route.go
5f133ff 
Signed-off-by: HoangTheQuyen <38252060+HoangTheQuyen@users.noreply.github.com>
Signed-off-by: geotech <geotech@geotechs-MacBook-Pro-3.local>
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
@HoangTheQuyen
Update validate.go
5f03274 
Signed-off-by: HoangTheQuyen <38252060+HoangTheQuyen@users.noreply.github.com>
Signed-off-by: geotech <geotech@geotechs-MacBook-Pro-3.local>
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
@HoangTheQuyen
update unit test for grpcroute
6f8d85c 
Signed-off-by: geotech <geotech@geotechs-MacBook-Pro-3.local>
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
@HoangTheQuyen
Update certgen-job.yaml
27ab4fa 
Signed-off-by: HoangTheQuyen <38252060+HoangTheQuyen@users.noreply.github.com>
Signed-off-by: geotech <geotech@geotechs-MacBook-Pro-3.local>
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
@HoangTheQuyen
Update certgen-job.yaml
1314c74 
Signed-off-by: HoangTheQuyen <38252060+HoangTheQuyen@users.noreply.github.com>
Signed-off-by: geotech <geotech@geotechs-MacBook-Pro-3.local>
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
@HoangTheQuyen
Update deploy_and_ns.yaml
8995cb8 
Signed-off-by: HoangTheQuyen <38252060+HoangTheQuyen@users.noreply.github.com>
Signed-off-by: geotech <geotech@geotechs-MacBook-Pro-3.local>
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
@HoangTheQuyen
Update certgen-job.yaml
4a2d228 
Signed-off-by: HoangTheQuyen <38252060+HoangTheQuyen@users.noreply.github.com>
Signed-off-by: geotech <geotech@geotechs-MacBook-Pro-3.local>
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
@HoangTheQuyen
resolve conflic
1a13729 
Signed-off-by: geotech <geotech@geotechs-MacBook-Pro-3.local>
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
@HoangTheQuyen
fix conflic
9f2a352 
Signed-off-by: geotech <geotech@geotechs-MacBook-Pro-3.local>
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
@dependabot @HoangTheQuyen
build(deps): bump google.golang.org/grpc from 1.51.0 to 1.52.0 (#918)
65ef999 
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.51.0 to 1.52.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.51.0...v1.52.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
@Xunzhuo @HoangTheQuyen
chore: add devcontainer to gitignore (#921)
d8571b2 
Signed-off-by: Xunzhuo <bitliu@tencent.com>

Signed-off-by: Xunzhuo <bitliu@tencent.com>
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
@danehans @HoangTheQuyen
Adds EnvoyProxy Support to Kubernetes Provider (#861)
4187934 
Adds EnvoyProxy Support to Kube Provider

Signed-off-by: danehans <daneyonhansen@gmail.com>

Signed-off-by: danehans <daneyonhansen@gmail.com>
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
@dependabot @HoangTheQuyen
build(deps): bump yamllint from 1.28.0 to 1.29.0 in /tools/src/yamlli…
956401e 
…nt (#917)

Bumps [yamllint](https://github.com/adrienverge/yamllint) from 1.28.0 to 1.29.0.
- [Release notes](https://github.com/adrienverge/yamllint/releases)
- [Changelog](https://github.com/adrienverge/yamllint/blob/master/CHANGELOG.rst)
- [Commits](adrienverge/yamllint@v1.28.0...v1.29.0)

---
updated-dependencies:
- dependency-name: yamllint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
danehans and others added 3 commits January 17, 2023 17:18
@danehans @HoangTheQuyen
Adds EnvoyProxy to Translator and Kube Infra Manager (#924)
5a1387f 
Adds EnvoyProxy to Translator and Infra Mgr

Signed-off-by: danehans <daneyonhansen@gmail.com>

Signed-off-by: danehans <daneyonhansen@gmail.com>
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
@HoangTheQuyen
update unit test for valid envoy proxy
fa7c2d2 
Signed-off-by: HoangTheQuyen <HoangTheQuyen01@gmail.com>
@HoangTheQuyen
Merge branch 'main' into main
9ce5605 
Signed-off-by: HoangTheQuyen <38252060+HoangTheQuyen@users.noreply.github.com>
@danehans
Copy link
Copy Markdown
Contributor

danehans commented Jan 17, 2023

@HoangTheQuyen I appreciate your willingness to contribute to EG. @arkodg is assigned #642 so please coordinate with him on what, if any, pieces of this PR can be accepted. I believe he has kept #805 as a draft due to the churn that the gatewayapi translator is undergoing. EG has plenty of issues that can use attention. Please let us know if you would like to take any of the issues on and we'll assign you.

@HoangTheQuyen
Copy link
Copy Markdown
Author

HoangTheQuyen commented Jan 18, 2023 •
edited
Loading

@HoangTheQuyen I appreciate your willingness to contribute to EG. @arkodg is assigned #642 so please coordinate with him on what, if any, pieces of this PR can be accepted. I believe he has kept #805 as a draft due to the churn that the gatewayapi translator is undergoing. EG has plenty of issues that can use attention. Please let us know if you would like to take any of the issues on and we'll assign you.

Tks

danehans

Thanks for the reply @danehans. And we are being waiting at here so we can continue this section right? @danehans @arkodg

@danehans
Copy link
Copy Markdown
Contributor

danehans commented Jan 18, 2023

We are waiting for @arkodg to update #805.

@HoangTheQuyen
Copy link
Copy Markdown
Author

HoangTheQuyen commented Jan 20, 2023

We are waiting for @arkodg to update #805.

Tks @danehans. I'll come back when that ticket #805 reopen

@HoangTheQuyen
Merge branch 'main' into main
24dcd24 
Signed-off-by: HoangTheQuyen <38252060+HoangTheQuyen@users.noreply.github.com>
@HoangTheQuyen
Merge branch 'envoyproxy:main' into main
ad7bd9a
@danehans
Copy link
Copy Markdown
Contributor

danehans commented Jan 31, 2023

I'm closing this PR out in favor of #805. If any additional work is required, feel free to create smaller, more targeted PRs.

@danehans danehans closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HoangTheQuyen @zirain @danehans @Xunzhuo