Hamming: Description.md, language simplification#1360
Conversation
rpottsoh
changed the title
rpottsoh
left a comment
rpottsoh
left a comment
There was a problem hiding this comment.
Looks good, just a small misspelling.
|
@rpottsoh Updated. Thanks :) |
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
interesting thing - before this PR there were two instances of "Hamming distance" and one instance of "Hamming difference".
After this PR there would be one instance of "Hamming distance" and three of "hamming difference".
I suggest that this would be a good time to discuss whether:
- This PR is a good time to change to using just one of those two options
- It is good to use just one of those two options, but can just file an issue for it and don't need to do it in this PR
- It is good to use both of these options, therefore no changes need be made here
|
Nice catch @petertseng. I think it should be hamming distance. Search for hamming difference yields hamming distance.... |
|
Happy to change it to "hamming distance" everywhere. |
I'm also in favor of using "hamming distance". |
|
I've added another commit (we can squash on merge). |
|
Thanks @iHiD! |
|
Great. Thanks, all. |
Relevant PRs: 1) Test cases: - exercism/problem-specifications#625 - exercism/problem-specifications#844 - exercism/problem-specifications#845 - exercism/problem-specifications#875 - exercism/problem-specifications#953 - exercism/problem-specifications#1129 - exercism/problem-specifications#1389 2) README: - exercism/problem-specifications#1360 Basically adds every test case from the current canonical-data.json without deleting the old ones.
4 participants
With reference to exercism/exercism#4155 (comment) I propose making the language of this exercise easier for non-english speakers.