hamming: Simplify two tests so the difference is easily spotted.#953
hamming: Simplify two tests so the difference is easily spotted.#953Stargator merged 1 commit intoexercism:masterfrom
Conversation
Insti
left a comment
There was a problem hiding this comment.
I like this 👍
I also think the minor version increment is correct here.
|
I agree that minor version increment is correct because test input was changed, and it is a case listed in https://github.com/exercism/problem-specifications/blob/master/README.md#minor-version-changes. I would also like to point out that this PR did not increase minor version, but increased patch version. This doesn't matter for any track I maintain, so I don't need anything to change. If it matters for your track, you should change the minor version. |
I think that the change that happened was the correct one. So it seems I disagree with the documentation. |
Relevant PRs: - exercism/problem-specifications#625 - exercism/problem-specifications#844 - exercism/problem-specifications#845 - exercism/problem-specifications#875 - exercism/problem-specifications#953 - exercism/problem-specifications#1129 - exercism/problem-specifications#1389 Basically adds every test case from the current canonical-data.json without deleting the old ones.
Relevant PRs: 1) Test cases: - exercism/problem-specifications#625 - exercism/problem-specifications#844 - exercism/problem-specifications#845 - exercism/problem-specifications#875 - exercism/problem-specifications#953 - exercism/problem-specifications#1129 - exercism/problem-specifications#1389 2) README: - exercism/problem-specifications#1360 Basically adds every test case from the current canonical-data.json without deleting the old ones.
I feel like the cases
"non-unique character in first strand"and"non-unique character in second strand"are not clear in how the respective strand has a non-unique character.So I suggest simplifying it. Otherwise, I would be fine with switching them as seen below. Where it's clear by the pattern of the other strand that the strand with the non-unique character doesn't follow the expected pattern.
{ "description": "non-unique character in first strand", "property": "distance", "strand1": "AGG", "strand2": "AGA", "expected": 1 }, { "description": "non-unique character in second strand", "property": "distance", "strand1": "AGA", "strand2": "AGG", "expected": 1 },```