Skip to content

hamming: test for empty input#844

Merged
katrinleinweber merged 1 commit intomasterfrom
katrinleinweber-patch-1
Jun 24, 2017
Merged

hamming: test for empty input#844
katrinleinweber merged 1 commit intomasterfrom
katrinleinweber-patch-1

Conversation

@katrinleinweber
Copy link
Copy Markdown
Contributor

@katrinleinweber katrinleinweber commented Jun 24, 2017 •
edited
Loading

as proposed in #827

@katrinleinweber katrinleinweber merged commit b3daec1 into master Jun 24, 2017
@katrinleinweber katrinleinweber deleted the katrinleinweber-patch-1 branch June 24, 2017 14:40
@katrinleinweber katrinleinweber changed the title hamming: test for empty input (as proposed in #827) hamming: test for empty input Jun 24, 2017
@stkent
Copy link
Copy Markdown
Contributor

stkent commented Jun 24, 2017

Just a heads up, this should have been a change to 1.1.0 per https://github.com/exercism/problem-specifications#minor-version-changes (my emphasis):

MINOR version changes

The MINOR version should change when you add functionality in a backwards-compatible manner, make non-breaking changes that alter the meaning of the test suite, make previously passing solutions possibly fail, or failing solutions fail at a different spot.

There are examples of changes requiring a MINOR version change:

  • Adding or deleting test cases.
  • Changing the test cases inputs and/or outputs.
  • Changing the test cases ordering.

@katrinleinweber
Copy link
Copy Markdown
Contributor Author

katrinleinweber commented Jun 24, 2017

Argh, my apologies! Shall I fix my version bump?

I looked through CONTRIBUTING.md: shall I also include the versioning guidelines there?

@stkent
Copy link
Copy Markdown
Contributor

stkent commented Jun 24, 2017

No worries! I think a quick bump now would be good; it's unlikely that anyone has regenerated yet :)

It does seem like the specification should be linked in the contributing guidelines - if you're also able to separately address that it would be awesome!

This was referenced Jun 24, 2017
Merged
Merged
@petertseng
Copy link
Copy Markdown
Member

petertseng commented Jun 27, 2017

needed needs https://help.github.com/articles/closing-issues-via-commit-messages/

emcoding pushed a commit that referenced this pull request Nov 19, 2018
@Insti
Merge pull request #844 from Insti/add_extra_canonical_data_accessors
b9aaefc 
generator: Add canonical data accessors for input and expected values
ZapAnton added a commit to ZapAnton/rust that referenced this pull request Nov 20, 2018
@ZapAnton
hamming: Updated the exercise to the 2.1.1
4adf847 
Relevant PRs:
- exercism/problem-specifications#625
- exercism/problem-specifications#844
- exercism/problem-specifications#845
- exercism/problem-specifications#875
- exercism/problem-specifications#953
- exercism/problem-specifications#1129
- exercism/problem-specifications#1389

Basically adds every test case from the current canonical-data.json
without deleting the old ones.
@ZapAnton ZapAnton mentioned this pull request Nov 20, 2018
Merged
ZapAnton added a commit to ZapAnton/rust that referenced this pull request Nov 21, 2018
@ZapAnton
hamming: Updated the exercise to the 2.1.1
eb36fc6 
Relevant PRs:

1) Test cases:

- exercism/problem-specifications#625
- exercism/problem-specifications#844
- exercism/problem-specifications#845
- exercism/problem-specifications#875
- exercism/problem-specifications#953
- exercism/problem-specifications#1129
- exercism/problem-specifications#1389

2) README:

- exercism/problem-specifications#1360

Basically adds every test case from the current canonical-data.json
without deleting the old ones.
petertseng pushed a commit to petertseng/exercism-ceylon that referenced this pull request Sep 1, 2019
@katrinleinweber @petertseng
hamming: Move empty strands test to be first
d2c03dd 
retroactive application of 1.1.0

as proposed in exercism/problem-specifications#844

exercism/problem-specifications#844
petertseng pushed a commit to petertseng/exercism-ceylon that referenced this pull request Sep 1, 2019
@katrinleinweber @petertseng
hamming: Move empty strands test to be first
23ac463 
retroactive application of 1.1.0

as proposed in exercism/problem-specifications#827

exercism/problem-specifications#844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NobbZ NobbZ NobbZ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@katrinleinweber @stkent @petertseng @NobbZ