Merge master to next #191
Merged
Merge master to next #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is used for a literal.
C++: Remove empty files.
C#: Regression test for extractor
C++: Fix spurious extra qualified names for enum constants within a class
Approved by asger-semmle
The `InstructionSanity::duplicateOperand` predicate used `count` instead of `strictcount`. The 0-case of this `count` was as large as the Cartesian product of `Instruction` and `OperandTag`, which made `duplicateOperand` take forever to compute on large snapshots.
Merge rc/1.18 into master
C++: IR: InstructionSanity::duplicateOperand perf
C++: Document the three predicates for array size
…ense-fix Approved by asger-semmle
This query gets optimized badly, and it has started timing out when we run it on our own code base. Most of the evaluation time is spent in an RA predicate named `#select#cpe#1#f#antijoin_rhs#1`, which takes 1m36s a Wireshark snapshot. This restructuring of the code makes the problematic RA predicate go away.
C++: Restructure UnsafeUseOfStrcat for performance
Approved by esben-semmle
jbj
added
depends on internal PR
ghost
previously approved these changes
Sep 13, 2018
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
The content of javascript/ql/test/query-tests/Security/CWE-730/RegExpInjection.js has been merged correctly.
…sage Approved by yh-semmle
jbj
force-pushed
the
merge-master-next-20180913
branch
from
9571503 to
9886e4a
Compare
Contributor
Author
|
Note: no tests should run for this PR. The tests are running on the internal PR, and the two PRs can be merged together when the internal tests pass. |
nickrolfe
approved these changes
Sep 14, 2018
aibaars
added a commit
that referenced
this pull request
Oct 14, 2021
fix snake_casing of camelCased identifiers
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Jan 17, 2022
…ions Extract local class declarations
MathiasVP
pushed a commit
to MathiasVP/ql
that referenced
this pull request
Aug 10, 2025
Sync Main: More Misc Token Bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the GitHub UI there was a conflict in
javascript/ql/test/query-tests/Security/CWE-730/RegExpInjection.js(@esben-semmle), so I did the merge on the command line, where there was no conflict.